fix: an API for partial read FixVec is incorrect#49
Merged
chaoticlonghair merged 3 commits intoJul 29, 2021
Conversation
chaoticlonghair
force-pushed
the
pr/fix-a-bug
branch
from
b851841 to
86354da
Compare
zhangsoledad
previously approved these changes
Jul 29, 2021
driftluo
approved these changes
Jul 29, 2021
zhangsoledad
approved these changes
Jul 29, 2021
bors Bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Jul 30, 2021
2884: chore(deps): bump molecule from 0.7.1 to 0.7.2 r=doitian,driftluo a=yangby-cryptape Bumps [molecule](https://github.com/nervosnetwork/molecule/) from 0.7.1 to 0.7.2. <details><summary>Important Commits</summary><br/> - [fix: an API for partial read FixVec is incorrect](nervosnetwork/molecule@86354da) Not affect CKB, but we expose the incorrect methods. See nervosnetwork/molecule#49 for more details. </details> Co-authored-by: Boyu Yang <yangby@cryptape.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reader:
molecule/tools/codegen/src/generator/languages/rust/reader/implementation.rs
Lines 122 to 125 in 706c5e0
Builder:
molecule/tools/codegen/src/generator/languages/rust/builder/implementation.rs
Lines 112 to 114 in 706c5e0