Skip to content

fix: an API for partial read FixVec is incorrect #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaoticlonghair merged 3 commits into from
Jul 29, 2021
Merged

fix: an API for partial read FixVec is incorrect #49

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03c2872
ci: lock the rust toolchain in the ci script
chaoticlonghair Jul 29, 2021
86354da
fix: an API for partial read FixVec is incorrect
chaoticlonghair Jul 29, 2021
5b4b481
chore: bump version to v0.7.2
chaoticlonghair Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
toolchain: 1.52.1
override: true
components: rustfmt
- name: Run
Expand All @@ -35,7 +35,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
toolchain: 1.52.1
override: true
components: clippy
- name: Run
Expand All @@ -47,7 +47,7 @@ jobs:
matrix:
os: [ ubuntu-latest ]
rust:
- stable
- 1.52.1
- 1.41.0 # MSRV
fail-fast: true
max-parallel: 2
Expand All @@ -69,7 +69,7 @@ jobs:
matrix:
os: [ ubuntu-latest ]
rust:
- stable
- 1.52.1
- 1.41.0 # MSRV
fail-fast: true
max-parallel: 2
Expand Down
9 changes: 9 additions & 0 deletions examples/tests-loader/src/generators/rust.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,15 @@ impl GenTest for types::Vector {
.build();
let expected = #name::from_slice(#expected).unwrap();
#assert_stmt
assert_eq!(
result.total_size(),
result.as_slice().len(),
"\nstruct: {}:\n data: {:#x}\n partial read total_size: {}, actual: {}\n",
#name::NAME,
result,
result.total_size(),
result.as_slice().len()
);
}
);
vec![test]
Expand Down
2 changes: 1 addition & 1 deletion tools/codegen/src/generator/languages/rust/properties.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ impl DefProperties for ast::FixVec {
fn def_properties(&self) -> m4::TokenStream {
quote!(
pub fn total_size(&self) -> usize {
molecule::NUMBER_SIZE * (self.item_count() + 1)
molecule::NUMBER_SIZE + Self::ITEM_SIZE * self.item_count()
}
pub fn item_count(&self) -> usize {
molecule::unpack_number(self.as_slice()) as usize
Expand Down