Skip to content

Add a tag_id filter for all models which support tagging #18783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeremystretch opened this issue Feb 28, 2025 · 1 comment · Fixed by #18889
Closed

Add a tag_id filter for all models which support tagging #18783

jeremystretch opened this issue Feb 28, 2025 · 1 comment · Fixed by #18889
Assignees
@renatoalmeidaoliveira
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v4.3

Comments

@jeremystretch
Copy link
Member

NetBox version

v4.2.4

Feature type

Data model extension

Proposed functionality

Add a tag_id filter to NetBoxModelFilterSet, which will enable filtering of objects by tag ID. This should function similarly to the existing tag filter (which matches by tag slug). For example:

GET /api/dcim/sites/?tag_id=100&tag_id=200

Use case

This provides an alternative to referencing tags by their slugs, and may be needed in some specific scenarios (such as that described in #18757).

Database changes

N/A

External dependencies

N/A
@jeremystretch jeremystretch added complexity: low Requires minimal effort to implement needs milestone Awaiting prioritization for inclusion with a future NetBox release status: backlog Awaiting selection for work type: feature Introduction of new functionality to the application labels Feb 28, 2025
@jeremystretch jeremystretch mentioned this issue Feb 28, 2025
Closed
@jeremystretch jeremystretch added this to the v4.3 milestone Mar 12, 2025
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed needs milestone Awaiting prioritization for inclusion with a future NetBox release status: backlog Awaiting selection for work labels Mar 12, 2025
Merged
arthanson pushed a commit that referenced this issue Mar 25, 2025
@renatoalmeidaoliveira
Fixes: #18783 Add a tag_id filter for all models which support tagging (
9a1d936 
#18889)
jeremystretch added a commit that referenced this issue Apr 10, 2025
@jeremystretch
Revert "Fixes: #18783 Add a tag_id filter for all models which suppor…
5886f6e 
…t taggin…"

This reverts commit 9a1d936.
@jeremystretch jeremystretch mentioned this issue Apr 10, 2025
Merged
jeremystretch added a commit that referenced this issue Apr 10, 2025
@jeremystretch
Revert "Fixes: #18783 Add a tag_id filter for all models which suppor…
fe7fb94 
…t taggin…"

This reverts commit 9a1d936.
@jeremystretch jeremystretch reopened this Apr 10, 2025
@jeremystretch
Copy link
Member Author

PR #18889 was mistakenly merged into main.

jeremystretch pushed a commit that referenced this issue Apr 10, 2025
@renatoalmeidaoliveira @jeremystretch
Fixes: #18783 Add a tag_id filter for all models which support tagging (
74803c0 
#18889)
@jeremystretch jeremystretch mentioned this issue Apr 10, 2025
Merged
arthanson pushed a commit that referenced this issue Apr 11, 2025
@jeremystretch
Fixes: #18783 Add a tag_id filter for all models which support tagging (
5d7ed87 
#18889) (#19142)
@jeremystretch jeremystretch mentioned this issue May 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renatoalmeidaoliveira renatoalmeidaoliveira

Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v4.3
Development

Successfully merging a pull request may close this issue.

Fixes: #18783 Add a tag_id filter for all models which support tagging renatoalmeidaoliveira/netbox
2 participants
@jeremystretch @renatoalmeidaoliveira