Skip to content

Fixes: #18783 Add a tag_id filter for all models which support tagging #18889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2025
Merged

Fixes: #18783 Add a tag_id filter for all models which support tagging #18889

merged 4 commits into from
Mar 25, 2025

Conversation

renatoalmeidaoliveira
Copy link
Collaborator

Fixes: #18783 Add a tag_id filter for all models which support tagging

Replicate TagFilter logic to TagIDFilter and implemented tag_id field to NetBoxModelFilterSet and ConfigTemplateFilterSet

Tested the FilterSet in REST, GraphQL, and in the UI by crafting an URL.

Since there already a Tag field in the FilterForm didn't implemented any new field.

@renatoalmeidaoliveira renatoalmeidaoliveira requested review from a team and arthanson and removed request for a team March 13, 2025 02:31
arthanson
arthanson requested changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good, the only thing is add it to docs/plugins/development/filtersets.py under TagFilter heading.

arthanson
arthanson requested changes Mar 24, 2025
View reviewed changes
@arthanson arthanson merged commit 9a1d936 into netbox-community:main Mar 25, 2025
3 checks passed
This was referenced Apr 10, 2025
Merged
Closed
jeremystretch pushed a commit that referenced this pull request Apr 10, 2025
@renatoalmeidaoliveira @jeremystretch
Fixes: #18783 Add a tag_id filter for all models which support tagging (
74803c0 
#18889)
@jeremystretch jeremystretch mentioned this pull request Apr 10, 2025
Merged
arthanson pushed a commit that referenced this pull request Apr 11, 2025
@jeremystretch
Fixes: #18783 Add a tag_id filter for all models which support tagging (
5d7ed87 
#18889) (#19142)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arthanson arthanson arthanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a tag_id filter for all models which support tagging
2 participants
@renatoalmeidaoliveira @arthanson