Fix aws labels cost tracking issue #228
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS tag validation issues were addressed by sanitizing process tags across multiple Nextflow modules. The primary problem involved illegal characters in tag values, such as
^
in restriction sites or=
in sample identifiers, which violate AWS resource label constraints.A consistent sanitization pattern,
replaceAll(/[^a-zA-Z0-9_-]/, '_')
, was applied. This regex replaces any character not a letter, number, underscore, or hyphen with an underscore, ensuring AWS compliance.Specific changes include:
modules/local/hicpro/get_restriction_fragments.nf
, theres_site
tag was sanitized (e.g.,^GATC
becomes_GATC
).modules/local/hicpro/dnase_mapping_stats.nf
,sample
andbam
tags were combined and sanitized (e.g.,sample = file.bam
becomessample___file_bam
).modules/nf-core/bwa/index/main.nf
,modules/nf-core/bowtie2/build/main.nf
, andmodules/nf-core/custom/getchromsizes/main.nf
,fasta
base names were sanitized (e.g.,genome.fasta
becomesgenome_fasta
).modules/nf-core/cooler/makebins/main.nf
, a syntax error"${meta.id}}"
was corrected to"${meta.id}"
.These modifications ensure all generated process tags adhere to AWS naming conventions, resolving potential deployment errors.
Closes #224