Skip to content

Deep comparing props in shouldComponentUpdate (usage with preact-compat) #287

Open
Open
Deep comparing props in shouldComponentUpdate (usage with preact-compat)#287

Description

@bassarisse
bassarisse
opened on May 30, 2017

Hey there,

I don't know if usage with preact-compat is something this lib intends to support, so I'll just ask. =)

I opened this issue there: preactjs/preact-compat#391

Is this something that could be fixed in react-helmet? Or should I just replace it with preact-helmet?

Thanks in advance!

Activity

  1. tannerlinsley commented on Mar 5, 2018

    @tannerlinsley
    tannerlinsley
    on Mar 5, 2018

    This affects React-Static users who opt for preact. What's the game plan here?

  2. kandebr commented on Apr 4, 2018

    @kandebr
    kandebr
    on Apr 4, 2018

    I'm using react 16.3.* (without preact) and I have the problem.. One of the props in shouldComponentUpdate is object of FiberNode, and this object has recursive link to himself (alternate field) and so deepClone will be crashed..

  3. esbenam commented on May 11, 2020

    @esbenam
    esbenam
    on May 11, 2020
    Contributor

    react-fast-compare just added support for Preact in react-fast-compare@3.1.1. Maybe this could be resolved by upgrading the dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions