Deep comparing props in shouldComponentUpdate (react-helmet usage) #391

Activity

1. bassarisse commented on May 30, 2017

   

   bassarisse

   on May 30, 2017

   Author

   More actions

   I just noticed that preact-helmet does this:

       shouldComponentUpdate(nextProps) {
           const props = {...nextProps};
           if (!props.children || !props.children.length) {
               delete props.children;
           }
           return !deepEqual(this.props, props);
       }

   Is this a good solution?

   👍React with 👍2Reacted by Marvin Hagemeister and Dan Arias
2. tannerlinsley commented on Mar 5, 2018

   

   tannerlinsley

   on Mar 5, 2018

   More actions

   This is affecting React-Static users who opt for preact. What's the game plan here?
3. petermikitsh commented on Sep 28, 2018

   

   petermikitsh

   on Sep 28, 2018

   More actions

   Any updates on this? I've attempted adopting preact, and I'm also using the latest react-helmet, and I noticed this issue.
4. petermikitsh commented on Sep 28, 2018

   

   petermikitsh

   on Sep 28, 2018

   More actions

   For my use case, the simplest option was to rewrite my code to use the v4 interface. If you're using v5 of react-helmet, the old API is still supported, so you can continue to use v5.

   Old code:

   <Helmet>
     <title>My Profile</title>
   </Helmet>

   New code:

   <Helmet title="My Profile"/>

   Infinite call stacks are gone now. 👍
5. esbenam commented on May 11, 2020

   

   esbenam

   on May 11, 2020

   Last edited by esbenam

   More actions

   react-fast-compare just added support for Preact in react-fast-compare@3.1.1. Maybe this could be resolved by upgrading the dependency in react-helmet (added a comment in the preact-compat issue)