Skip to content

Update AsyncGenerator to 0.14.0 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2019

Conversation

maca88
Copy link
Contributor

@maca88 maca88 commented Apr 13, 2019

The new version contains an updated NUnit plugin that simplifies the integration with NUnit.

@fredericDelaporte
Copy link
Member

Running the generator on your PR, I get additional changes in RedisCacheDefaultStrategyFixture.cs and RedisCachePerformanceFixture.cs.
Running it a second time, it does some other changes in these files.
Running it a third time, it goes back to this PR current state.

There is something fishy there.

@maca88 maca88 changed the title Update AsyncGenerator to 0.14.0 WIP - Update AsyncGenerator to 0.14.0 Apr 15, 2019
@maca88
Copy link
Contributor Author

maca88 commented Apr 15, 2019

I was able to reproduce this by running the generator a second time. The same issue happens also with the old version so it is not related to the recent change. Changed to WIP until I find a solution for it.

@maca88
Copy link
Contributor Author

maca88 commented Apr 30, 2019

It turned out that the issue was not related to the generator itself but rather to the compilation of the project. NHibernate was resolved two times when compiling NHibernate.Caches.StackExchangeRedis.Tests and NHibernate.Caches.StackExchangeRedis projects, which produced duplicate symbols for the same assembly causing inconsistent results when searching for NHibernate types references. By setting ImplicitlyExpandNETStandardFacades to false, NHibernate is resolved only once, which fixes the issue.

@maca88 maca88 changed the title WIP - Update AsyncGenerator to 0.14.0 Update AsyncGenerator to 0.14.0 Apr 30, 2019
Copy link
Member

@fredericDelaporte fredericDelaporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@fredericDelaporte fredericDelaporte merged commit 049d69b into nhibernate:master May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants