Upgrade AsyncGenerator to 0.14.0 #2126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
reviewed
Apr 14, 2019
| #if NETFX | ||
| [Test, Ignore("Not fixed yet.")] | ||
| [Description("SqlClient: The batcher should run all different INSERT queries in only one roundtrip.")] | ||
| public async Task SqlClientOneRoundTripForUpdateAndInsertAsync() |
There was a problem hiding this comment.
I didn't get it why this was removed.
There was a problem hiding this comment.
Until now the generator ignored only tests that had the Ignore attribute on the class, now I've applied the same rule also for methods.
maca88
changed the title
|
I've changed to WIP until the issue in nhibernate/NHibernate-Caches/pull/65 is resolved. For some reason the issue does not happen for this project even when regenerating multiple times. |
maca88
changed the title
|
Removed WIP as the mentioned issue is not related to the generator. |
|
A conflict has appeared in the meantime, if you have not seen it. |
|
UPD: My bad, I had a dirty branch. |
hazzik
approved these changes
May 5, 2019
hazzik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version contains an updated NUnit plugin that simplifies the integration with NUnit.