Port HQL Entity Join #2025
Merged
Port HQL Entity Join #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
commented
Feb 27, 2019
| @@ -1195,14 +1256,7 @@ public void Visit(IASTNode node) | |||
| { | |||
| DotNode dotNode = ( DotNode ) node; | |||
| FromElement fromElement = dotNode.FromElement; | |||
| if ( _referencedFromElement != null ) | |||
| { | |||
| if ( fromElement != _referencedFromElement ) | |||
There was a problem hiding this comment.
It seems this check was completely removed to also fix the following hibernate issue. I've added CrossJoinAndWithClause test to simulate it and this exception is indeed need to be removed. But this test still fails due to some other issue (theta style join is simply skipped in generated SQL added in a wrong order).
hazzik
previously approved these changes
Feb 28, 2019
hazzik
force-pushed
the
hqlEntityJoin
branch
from
1717994 to
11bc49d
Compare
hazzik
approved these changes
Feb 28, 2019
This was referenced Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a port for the following hibernate commit adding support for explicit joins on unrelated classes
Fixes #981