Fix theta-style joins for entity joins #3137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
force-pushed
the
Fix-GH3113
branch
from
916c1c3 to
9d244e5
Compare
hazzik
approved these changes
Aug 28, 2022
|
Before merging, I have to compare a test run on Oracle8i dialect without the change to one with the change, in order to make sure it does not break anything new. |
bahusoid
approved these changes
Aug 29, 2022
|
Here are the test results. Down from 563 failures to 511, no new failure seen. (But checked manually.) A test run on 5.2.x have "only" an hundred failures or so, with maybe 2 000 less tests. I think there is quite a bunch of other regressions for Oracle8i in 5.3.x, but it is a bit tedious to detect manually which tests are newly failing. |
|
I think "we do not care" and should deprecate all older Oracle dialects. |
|
I should have rewritten the commit message a bit better, sorry for having overlooked this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal fix proposal for #3113, which is a 5.3.0 regression introduced by #2327 along with #2025.
This trouble does by the way demonstrate that we lack an automated tests run for dialects using only theta style joins. Hundreds of tests fail for such a dialect, and maybe there is a bunch of them which are regressions.