Fix joining with an inherited property from another table for Linq provider #2581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maca88
changed the title
bahusoid
reviewed
Oct 11, 2020
maca88
commented
Oct 12, 2020
| public bool ContainsBaseMember(JoinClause joinClause) | ||
| { | ||
| // Visit the join inner key only for entities that have subclasses | ||
| if (joinClause.InnerSequence is ConstantExpression constantNode && |
There was a problem hiding this comment.
Constant check seems to be enough as join o2 in db.Mammals.Where(o => o.Pregnant) is not supported.
bahusoid
approved these changes
Oct 13, 2020
Merged
bahusoid
pushed a commit
to bahusoid/nhibernate-core
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a regression made by #2327. When merging into master only the test cases should be merged as #2361 makes this fix obsolete.
Fixes #2580