Merge 5.3.4 #2593
Merged
Merge 5.3.4 #2593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nhibernate#2559 Co-authored-by: maca88 <[email protected]>
And document a missing breaking change. Fixes nhibernate#2578
hazzik
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge proposal for merging 5.3.4 into master.
This PR is not meant to be merged directly, I will push my change directly to master if validated. (So please avoid merging anything else to master in the meantime.)
I am doing this PR instead of merging directly because two 5.3.4 PRs were requiring conflict resolutions, which I have done following their instructions. See #2581 and #2550. So I prefer to check the CI builds before merging.