Fix some Contains subqueries failures with Linq #3212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
It was not clear for me if this was an improvement or a bug fix. Checking the test case, the query throws without the change. So, labeling as bug. |
|
Yes, it's a bug. |
|
Though not a recent regression, should we target 5.4.1 instead of master? |
fredericDelaporte
changed the title
fredericDelaporte
approved these changes
Jan 1, 2023
bahusoid
reviewed
Jan 1, 2023
bahusoid
changed the title
bahusoid
added a commit
that referenced
this pull request
Apr 2, 2023
|
Replaced by #3274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most likely an old regression, where the smartness around LINQ Contains queries ignores the fact that source to the Contains can contain body clauses. In my case it was the use of
MappedAsthat was left hanging in the querymodel, even thoughremoveMappedAsCallswas set to true, but I guess there may be other issues.