Improve LINQ Contains subquery parameter detection #3274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
reviewed
Mar 31, 2023
| @@ -648,6 +649,9 @@ where sheet.Users.Contains(user) | |||
| [Test] | |||
| public void TimesheetsWithEnumerableContainsOnSelect() | |||
| { | |||
| if (Dialect is MsSqlCeDialect) | |||
There was a problem hiding this comment.
fixes SqlServerCe test for #3271
System.IndexOutOfRangeException : Index was outside the bounds of the array.
at System.Data.SqlServerCe.SqlCeCommand.GetQueryParameters(IntPtr pQpCommand)
at System.Data.SqlServerCe.SqlCeCommand.CreateDataBindings()
at System.Data.SqlServerCe.SqlCeCommand.CompileQueryPlan()
hazzik
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3212
We should always try to detect parameters. And parameter detection shouldn't skip query transformation.
Also fixes SqlServerCe test for #3271