Skip to content

fs: add support to Dir for explicit resource management #58206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2025
Merged

fs: add support to Dir for explicit resource management #58206

merged 1 commit into from
May 11, 2025
+54 −7

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 7, 2025

No description provided.

@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label May 7, 2025
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels May 7, 2025
@codecov Codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (942862f) to head (a799f76).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58206      +/-   ##
==========================================
- Coverage   90.20%   90.18%   -0.02%     
==========================================
  Files         629      629              
  Lines      186641   186658      +17     
  Branches    36667    36660       -7     
==========================================
- Hits       168353   168337      -16     
- Misses      11115    11118       +3     
- Partials     7173     7203      +30
Files with missing lines Coverage Δ
lib/internal/fs/dir.js 94.45% <100.00%> (+0.27%) ⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 7, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66673/

LiviaMedeiros
LiviaMedeiros approved these changes May 7, 2025
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66702/

aduh95
aduh95 commented May 8, 2025
View reviewed changes
@aduh95 aduh95 added blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 8, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels May 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66740/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 4a86be2 into nodejs:main May 11, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4a86be2

@aduh95 aduh95 deleted the fs-using-dir branch May 11, 2025 19:34
targos pushed a commit that referenced this pull request May 16, 2025
@aduh95 @targos
fs: add to Dir support for explicit resource management
fcead7c 
PR-URL: #58206
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
@aduh95 aduh95 mentioned this pull request May 19, 2025
Closed
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
nodejs-github-bot added a commit that referenced this pull request May 20, 2025
@nodejs-github-bot
2025-05-21, Version 24.1.0 (Current)
587a88b 
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
fs:
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
test_runner:
  * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202

PR-URL: #58406
aduh95 pushed a commit that referenced this pull request May 21, 2025
@nodejs-github-bot @aduh95
2025-05-21, Version 24.1.0 (Current)
0f5fb04 
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
fs:
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
test_runner:
  * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202

PR-URL: #58406
aduh95 added a commit that referenced this pull request Jun 10, 2025
@aduh95
fs: add to Dir support for explicit resource management
1b38476 
PR-URL: #58206
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Merged
nodejs-github-bot added a commit that referenced this pull request Jun 10, 2025
@nodejs-github-bot
2025-06-24, Version 22.17.0 'Jod' (LTS)
1b32c65 
Notable changes:

assert:
  * (SEMVER-MINOR) mark partialDeepStrictEqual() as stable (Ruben Bridgewater) #57370
doc:
  * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564
  * deprecate HTTP/2 priority signaling (Matteo Collina) #58313
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * mark multiple APIs stable (James M Snell) #57513
fs:
  * (SEMVER-MINOR) add autoClose option to FileHandle readableWebStream (James M Snell) #58548
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
http:
  * deprecate instantiating classes without new (Yagiz Nizipli) #58518
http2:
  * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560
lib:
  * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541
src,permission:
  * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579
util:
  * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437

PR-URL: #58665
@Renegade334 Renegade334 mentioned this pull request Jun 12, 2025
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jun 20, 2025
@Renegade334
fs: make Dir disposers idempotent
ce546e4 
PR-URL: #58692
Refs: #58206
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Jun 23, 2025
@nodejs-github-bot @aduh95
2025-06-24, Version 22.17.0 'Jod' (LTS)
6eff5f5 
Notable changes:

assert:
  * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370
doc:
  * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518
  * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564
  * deprecate HTTP/2 priority signaling (Matteo Collina) #58313
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * mark multiple APIs stable (James M Snell) #57513
fs:
  * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
http2:
  * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560
lib:
  * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541
src,permission:
  * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579
util:
  * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437

PR-URL: #58665
RafaelGSS pushed a commit that referenced this pull request Jun 23, 2025
@Renegade334 @RafaelGSS
fs: make Dir disposers idempotent
96c78d7 
PR-URL: #58692
Refs: #58206
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Jun 24, 2025
@nodejs-github-bot @aduh95
2025-06-24, Version 22.17.0 'Jod' (LTS)
3567fa7 
Notable changes:

assert:
  * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370
doc:
  * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518
  * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564
  * deprecate HTTP/2 priority signaling (Matteo Collina) #58313
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * mark multiple APIs stable (James M Snell) #57513
fs:
  * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
http2:
  * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560
lib:
  * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541
src,permission:
  * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579
util:
  * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437

PR-URL: #58665
aduh95 pushed a commit that referenced this pull request Jun 25, 2025
@nodejs-github-bot @aduh95
2025-06-24, Version 22.17.0 'Jod' (LTS)
ac540c0 
Notable changes:

assert:
  * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370
doc:
  * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518
  * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564
  * deprecate HTTP/2 priority signaling (Matteo Collina) #58313
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * mark multiple APIs stable (James M Snell) #57513
fs:
  * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
http2:
  * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560
lib:
  * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541
src,permission:
  * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579
util:
  * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437

PR-URL: #58665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @jasnell @LiviaMedeiros