Skip to content

doc: add puskin to collaborators #58308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

doc: add puskin to collaborators #58308

merged 1 commit into from
May 13, 2025
+3 −0

Conversation

puskin
Copy link
Contributor

@puskin puskin commented May 13, 2025

Fixes: #58088

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels May 13, 2025
@puskin puskin added notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels May 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @puskin.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @puskin. Please 👍 to approve.

aduh95
aduh95 reviewed May 13, 2025
View reviewed changes
.mailmap
@@ -204,6 +204,7 @@ George Adams <[email protected]> <[email protected]>
Gerhard Stöbich <[email protected]>
Gibson Fahnestock <[email protected]> <[email protected]>
Gil Pedersen <[email protected]> <[email protected]>
Giovanni Bucci <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why this addition?

Copy link
Member

@marco-ippolito marco-ippolito May 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the find-inactive tool was flagging it. I think there is a mismatch between emails

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, it must the name that mismatches (commit author is Giovanni <[email protected]>, while the tool is looking for Giovanni Bucci <[email protected]>)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is part of this doc: https://github.com/nodejs/node/blob/main/onboarding.md#exercise-make-a-pull-request-adding-yourself-to-the-readme .

It says:
Run tools/find-inactive-collaborators.mjs. If that command outputs your name, amend the commit to include an addition to the [mailmap](https://github.com/nodejs/node/blob/main/.mailmap) file. See [gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the format of the mailmap file.

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2025
@nodejs-github-bot nodejs-github-bot merged commit e8c06a5 into nodejs:main May 13, 2025
35 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e8c06a5

targos pushed a commit that referenced this pull request May 16, 2025
@puskin @targos
doc: add puskin to collaborators
b7d1bfa 
Fixes: #58088
PR-URL: #58308
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
nodejs-github-bot added a commit that referenced this pull request May 20, 2025
@nodejs-github-bot
2025-05-21, Version 24.1.0 (Current)
587a88b 
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
fs:
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
test_runner:
  * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202

PR-URL: #58406
aduh95 pushed a commit that referenced this pull request May 21, 2025
@nodejs-github-bot @aduh95
2025-05-21, Version 24.1.0 (Current)
0f5fb04 
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
fs:
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
test_runner:
  * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202

PR-URL: #58406
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@puskin @aduh95
doc: add puskin to collaborators
fdf7612 
Fixes: #58088
PR-URL: #58308
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Merged
nodejs-github-bot added a commit that referenced this pull request Jun 10, 2025
@nodejs-github-bot
2025-06-24, Version 22.17.0 'Jod' (LTS)
1b32c65 
Notable changes:

assert:
  * (SEMVER-MINOR) mark partialDeepStrictEqual() as stable (Ruben Bridgewater) #57370
doc:
  * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564
  * deprecate HTTP/2 priority signaling (Matteo Collina) #58313
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * mark multiple APIs stable (James M Snell) #57513
fs:
  * (SEMVER-MINOR) add autoClose option to FileHandle readableWebStream (James M Snell) #58548
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
http:
  * deprecate instantiating classes without new (Yagiz Nizipli) #58518
http2:
  * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560
lib:
  * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541
src,permission:
  * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579
util:
  * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437

PR-URL: #58665
aduh95 pushed a commit that referenced this pull request Jun 23, 2025
@nodejs-github-bot @aduh95
2025-06-24, Version 22.17.0 'Jod' (LTS)
6eff5f5 
Notable changes:

assert:
  * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370
doc:
  * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518
  * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564
  * deprecate HTTP/2 priority signaling (Matteo Collina) #58313
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * mark multiple APIs stable (James M Snell) #57513
fs:
  * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
http2:
  * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560
lib:
  * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541
src,permission:
  * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579
util:
  * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437

PR-URL: #58665
aduh95 pushed a commit that referenced this pull request Jun 24, 2025
@nodejs-github-bot @aduh95
2025-06-24, Version 22.17.0 'Jod' (LTS)
3567fa7 
Notable changes:

assert:
  * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370
doc:
  * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518
  * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564
  * deprecate HTTP/2 priority signaling (Matteo Collina) #58313
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * mark multiple APIs stable (James M Snell) #57513
fs:
  * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
http2:
  * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560
lib:
  * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541
src,permission:
  * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579
util:
  * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437

PR-URL: #58665
aduh95 pushed a commit that referenced this pull request Jun 25, 2025
@nodejs-github-bot @aduh95
2025-06-24, Version 22.17.0 'Jod' (LTS)
ac540c0 
Notable changes:

assert:
  * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370
doc:
  * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518
  * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564
  * deprecate HTTP/2 priority signaling (Matteo Collina) #58313
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * mark multiple APIs stable (James M Snell) #57513
fs:
  * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
http2:
  * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560
lib:
  * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541
src,permission:
  * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579
util:
  * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437

PR-URL: #58665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@aduh95 aduh95 aduh95 approved these changes

@pmarchini pmarchini pmarchini approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nominating Giovanni Bucci @puskin as a collaborator
5 participants
@puskin @nodejs-github-bot @aduh95 @marco-ippolito @pmarchini