http2: remove no longer userful options.selectPadding #58373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup cleanup on a previous PR. Current source code and doc explicitly states that `selectPadding` has been removed for all exports. Refs: nodejs#29144 Refs: https://nodejs.org/api/http2.html
|
Review requested:
|
nodejs-github-bot
added
http2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58373 +/- ##
==========================================
- Coverage 90.24% 90.23% -0.01%
==========================================
Files 633 633
Lines 186860 186867 +7
Branches 36675 36681 +6
==========================================
- Hits 168623 168620 -3
- Misses 11035 11039 +4
- Partials 7202 7208 +6
🚀 New features to boost your workflow:
|
lpinca
approved these changes
May 19, 2025
github-actions
bot
removed
the
request-ci
RafaelGSS
approved these changes
May 21, 2025
bjohansebas
approved these changes
May 24, 2025
jasnell
approved these changes
May 24, 2025
bjohansebas
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in ab68ad0 |
targos
pushed a commit
that referenced
this pull request
May 31, 2025
This is a followup cleanup on a previous PR. Current source code and doc explicitly states that `selectPadding` has been removed for all exports. Refs: #29144 Refs: https://nodejs.org/api/http2.html PR-URL: #58373 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup cleanup on a previous PR. Current source code and doc
explicitly states that
selectPaddinghas been removed for all exports.Refs: #29144
Refs: https://nodejs.org/api/http2.html