test: dispose of filehandles in filehandle.read tests #58543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiviaMedeiros
added
fs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58543 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.01%
==========================================
Files 635 635
Lines 187580 187580
Branches 36860 36854 -6
==========================================
- Hits 169265 169253 -12
- Misses 11101 11115 +14
+ Partials 7214 7212 -2 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Jun 2, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jun 2, 2025
LiviaMedeiros
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9e35ddc |
targos
pushed a commit
that referenced
this pull request
Jun 6, 2025
PR-URL: #58543 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-fs-read-empty-buffer.jsdid not close used filehandle.test-fs-read-offset-nullreused same variable in async tests, creating potential race condition.