Skip to content

src: make global error message vectors const in contextify #58580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

src: make global error message vectors const in contextify #58580

merged 1 commit into from
Jun 10, 2025
+10 −9

Conversation

mertcanaltin
Copy link
Member

@mertcanaltin mertcanaltin commented Jun 4, 2025 •
edited
Loading

I converted esm_syntax_error_messages and throws_only_in_cjs_error_messages to const vector

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Jun 4, 2025
@mertcanaltin mertcanaltin force-pushed the mert/refactor/contextify-memory-safety-perf branch from fd41107 to 71dd334 Compare June 4, 2025 21:38
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (641653b) to head (faf8ce9).
Report is 47 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58580      +/-   ##
==========================================
- Coverage   90.21%   90.20%   -0.02%     
==========================================
  Files         635      635              
  Lines      187494   187511      +17     
  Branches    36838    36815      -23     
==========================================
- Hits       169144   169140       -4     
- Misses      11145    11171      +26     
+ Partials     7205     7200       -5
Files with missing lines Coverage Δ
src/node_contextify.cc 81.24% <ø> (-0.04%) ⬇️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67279/

addaleax
addaleax approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could even be std::array, right?

addaleax
addaleax approved these changes Jun 5, 2025
View reviewed changes
@mertcanaltin mertcanaltin force-pushed the mert/refactor/contextify-memory-safety-perf branch 5 times, most recently from 19a716c to 7be95fa Compare June 5, 2025 23:43
@mertcanaltin mertcanaltin force-pushed the mert/refactor/contextify-memory-safety-perf branch from 7be95fa to faf8ce9 Compare June 5, 2025 23:45
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67360/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67371/

@addaleax addaleax mentioned this pull request Jun 9, 2025
Open
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit 238af6a into nodejs:main Jun 10, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 238af6a

seriousme pushed a commit to seriousme/node that referenced this pull request Jun 10, 2025
@mertcanaltin @seriousme
src: replace std::array with static arrays in contextify
095cb3b 
PR-URL: nodejs#58580
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Jun 16, 2025
@mertcanaltin @targos
src: replace std::array with static arrays in contextify
e9c6fa5 
PR-URL: #58580
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Closed
This was referenced Jun 23, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mertcanaltin @nodejs-github-bot @jasnell @addaleax @legendecas