2025-06-17, Version 24.3.0 (Current) #58727
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PR-URL: #58604 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #58614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #58615 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #58438 Fixes: #58322 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #58625 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #58628 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #58629 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #58630 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #58633 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
PR-URL: #58580 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #58567 Fixes: #58562 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #58610 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
PR-URL: #58490 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #58639 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]>
PR-URL: #58640 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
Split indirect eval import tests as they depends on the JS stack to resolve the referrer. PR-URL: #58637 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
When --import is used, the ESM loader is used to handle even pure CJS entry points, and it can run into CJS module facades in the evaluating state when the parent CJS module is being evaluated. In this case it should be allowed, since the ESM <-> CJS cycles that are meant to be disallowed (for the time being) should already be detected before evaluation and wouldn't get here, and CJS <-> CJS cycles are fine. PR-URL: #58598 Fixes: #58515 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
PR-URL: #58643 Refs: nodejs/typescript#24 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #58644 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #58537 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #58602 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: #58669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #58647 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Xuguang Mei <[email protected]>
Added serialization and deserialization support for `DOMException`. Co-Authored-By: jazelly <[email protected]> PR-URL: #58649 Fixes: #49181 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
PR-URL: #57419 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #58655 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
This commit refactors the CommonJS loader to remove TypeScript-specific extensions from the require.extensions object for compatibility with libraries that depended on it to initialize extenal TypeScript loaders. PR-URL: #58657 Refs: nodejs/typescript#37 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Xuguang Mei <[email protected]>
PR-URL: #58661 Fixes: #58660 Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #58667 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #58599 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #58603 Refs: #21371 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
`@stylistic/eslint-plugin-js` is deprecated in favor of the former. PR-URL: #58623 Refs: https://v4.eslint.style/packages/js Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
some test files manually check for `!process.features.inspector` to see if the tests should be skipped, the changes here update those checks to instead use the more appropriate `common.skipIfInspectorDisabled()` PR-URL: #58675 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: #58677 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.12. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #58698 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.12. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #58699 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
The existing `fileURLToPath()` does not handle the case where the input URL contains percent-encoded characters that are not valid UTF-8 sequences. This can lead to issues, for instance, when the URL is constructed using file names in non-Unicode encodings (like Shift-JIS). This commit introduces a new API, `fileURLToPathBuffer()`, which returns a `Buffer` representing the path, allowing for accurate conversion of file URLs to paths without attempting to decode the percent-encoded bytes into characters. PR-URL: #58700 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
refactor the test/parallel/test-repl-tab-complete.js file by: - making the tests in the file self-contained (instead of all of them sharing the same REPL instance and constantly calling `.clear` on it) - using the test runner with appropriate descriptions to make clearer what is being tested - extracting some tests in their own js test files (to increase isolation of the tests and help with issues such as flakiness) PR-URL: #58636 Reviewed-By: Giovanni Bucci <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #58685 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #58577 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
this commit reintroduces the REPL custom eval tests that have been introduced in #57691 but reverted in #57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed PR-URL: #57850 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Fixes: #58559 PR-URL: #58714 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Notable changes: doc: * add islandryu to collaborators (Shima Ryuhei) #58714 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #58643 test_runner: * (SEMVER-MINOR) support object property mocking (Idan Goshen) #58438 url: * (SEMVER-MINOR) add fileURLToPathBuffer API (James M Snell) #58700 PR-URL: #58727
github-actions
bot
added
release
|
Review requested:
|
|
I will defer this release to next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-06-17, Version 24.3.0 (Current), @RafaelGSS
Notable Changes
841609ac1c] - doc: add islandryu to collaborators (Shima Ryuhei) #58714839964ece8] - (SEMVER-MINOR) fs: allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #584909b28f40834] - (SEMVER-MINOR) module: remove experimental warning from type stripping (Marco Ippolito) #58643713fbad7b6] - (SEMVER-MINOR) test_runner: support object property mocking (Idan Goshen) #58438ef0230abaf] - (SEMVER-MINOR) url: add fileURLToPathBuffer API (James M Snell) #58700Commits
450f4815b3] - deps: update amaro to 1.0.0 (Node.js GitHub Bot) #586393aa2762e96] - deps: update sqlite to 3.50.1 (Node.js GitHub Bot) #5863080eac147e6] - deps: update simdjson to 3.13.0 (Node.js GitHub Bot) #58629dc1023878c] - deps: update zlib to 1.3.1-470d3a2 (Node.js GitHub Bot) #58628841609ac1c] - doc: add islandryu to collaborators (Shima Ryuhei) #587141cc77c7ee6] - doc: punctuation fix for Node-API versioning clarification (Jiacai Liu) #58599d59680348e] - doc: add path rules and validation for export targets in package.json (0hm☘️) #58604b6760b3379] - esm: syncify default path ofModuleLoader.load(Jacob Smith) #57419839964ece8] - (SEMVER-MINOR) fs: allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490b11da1115e] - http2: fix DEP0194 message (KaKa) #58669b1f60d2f18] - http2: add diagnostics channel 'http2.server.stream.close' (Darshan Sen) #586026390f70da2] - lib,src: support DOMException ser-des (Chengzhong Wu) #58649ff8a3691c4] - module: fix typescript import.meta.main (Marco Ippolito) #5866145f7d160ed] - module: refactor commonjs typescript loader (Marco Ippolito) #586579b28f40834] - (SEMVER-MINOR) module: remove experimental warning from type stripping (Marco Ippolito) #58643a3c7a63c73] - module: allow cycles in require() in the CJS handling in ESM loader (Joyee Cheung) #58598dfb0144490] - src: enhance error messages for unknown options (Pietro Marchini) #58677e9c6fa514c] - src: replace std::array with static arrays in contextify (Mert Can Altin) #585804347ce3dba] - src: add new CopyUtimes function to reduce code duplication (Dario Piotrowicz) #58625893999e0ee] - src: replace V8 Fast API todo comment with note comment (Dario Piotrowicz) #58614704b1fa075] - test: add tests for REPL custom evals (Dario Piotrowicz) #57850c39d570871] - test: reduce the use of private symbols in test-events-once.js (Yoshiya Hinosawa) #58685b7e488c77f] - test: refactor repl tab complete tests (Dario Piotrowicz) #58636ec808b3e06] - test: usecommon.skipIfInspectorDisabled()to skip tests (Dario Piotrowicz) #5867594e53d4f6c] - test: update WPT for urlpattern to 3ffda23e5a (Node.js GitHub Bot) #58537fa089d610f] - test: update WPT for dom/abort to dc928169ee (Node.js GitHub Bot) #58644aa657f0fc4] - test: split indirect eval import tests (Chengzhong Wu) #5863776e3c8aaf2] - test: update WPT for es-exceptions to 2f96fa1996 (Node.js GitHub Bot) #586407e34aa4eaa] - test: skip tests failing when run under root (Livia Medeiros) #5861085f062c22e] - test: deflake async-hooks/test-improper-order on AIX (Baki Gul) #58567181014a8fe] - test: cleanup status files (Filip Skokan) #58633a4d756068d] - test: close FileHandle objects in tests explicitly (James M Snell) #58615713fbad7b6] - (SEMVER-MINOR) test_runner: support object property mocking (Idan Goshen) #58438dc2f23e986] - tools: bumpbrace-expansionin/tools/clang-format(dependabot[bot]) #58699e6a1787140] - tools: bump brace-expansion from 1.1.11 to 1.1.12 in /tools/eslint (dependabot[bot]) #58698b22e970774] - tools: switch to@stylistic/eslint-plugin(Michaël Zasso) #58623268c8c1799] - tools: remove config.status undermake distclean(René) #58603c1f9791844] - tools: edit commit-queue workflow file (Antoine du Hamel) #58667afbaf9277b] - tools: improve release proposal linter (Antoine du Hamel) #5864717df800b90] - typings: add Atomics primordials (Renegade334) #58577ffff8ce3a4] - typings: add ZSTD_COMPRESS, ZSTD_DECOMPRESS to internalBinding (Meghan Denny) #58655ef0230abaf] - (SEMVER-MINOR) url: add fileURLToPathBuffer API (James M Snell) #58700