Skip to content

src: add new CopyUtimes function to reduce code duplication #58625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

src: add new CopyUtimes function to reduce code duplication #58625

merged 1 commit into from
Jun 9, 2025

Conversation

dario-piotrowicz
Copy link
Member

No description provided.

@dario-piotrowicz dario-piotrowicz requested a review from anonrig June 7, 2025 23:26
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 7, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.16%. Comparing base (3c351c2) to head (0208df9).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 60.00% 7 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58625      +/-   ##
==========================================
+ Coverage   90.13%   90.16%   +0.03%     
==========================================
  Files         636      636              
  Lines      187891   187881      -10     
  Branches    36878    36872       -6     
==========================================
+ Hits       169348   169402      +54     
+ Misses      11289    11235      -54     
+ Partials     7254     7244      -10
Files with missing lines Coverage Δ
src/node_file.cc 75.93% <60.00%> (+0.33%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dario-piotrowicz dario-piotrowicz added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67330/

@dario-piotrowicz dario-piotrowicz added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 8, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit bce60ab into nodejs:main Jun 9, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in bce60ab

@dario-piotrowicz dario-piotrowicz deleted the dario/node_file_CopyUtimes branch June 10, 2025 09:02
seriousme pushed a commit to seriousme/node that referenced this pull request Jun 10, 2025
@dario-piotrowicz @seriousme
src: add new CopyUtimes function to reduce code duplication
2fcc369 
PR-URL: nodejs#58625
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Jun 16, 2025
@dario-piotrowicz @targos
src: add new CopyUtimes function to reduce code duplication
4347ce3 
PR-URL: #58625
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Closed
This was referenced Jun 23, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dario-piotrowicz @nodejs-github-bot @jasnell @anonrig