Skip to content

docs: expanded description of team and goals #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

docs: expanded description of team and goals #5

merged 1 commit into from
Jan 7, 2020

Conversation

wesleytodd
Copy link
Member

Feedback welcome!

drawm
drawm reviewed Jan 6, 2020
View reviewed changes
Copy link

@drawm drawm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I suppose we will hone in on a more specific issue/goal/project during our first meetings

@wesleytodd
Copy link
Member Author

I suppose we will hone in on a more specific issue/goal/project during our first meetings

Yep! I just wanted to get more than my original dirty description of what the team would focus on. In sending this repo out I already had a few questions as to what specifically it was about.

@wesleytodd
Copy link
Member Author

wesleytodd commented Jan 6, 2020 •
edited
Loading

I will add this here (as I cannot make he change myself) as a proposal for a description of the repo description:

A place for Node.js Web-Server Framework authors and users to collaborate

@MylesBorins I am not sure if this is also something you can give me the ability to change. If not, no biggie, but I would request that we update it to this for now.

@MylesBorins
Copy link
Contributor

@wesleytodd updated

mhdawson
mhdawson approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wesleytodd
Copy link
Member Author

Anyone opposed to me fast-track'ing this? I would like to make sure that individuals who land here are clear on the scope of the team as we get started.

@RamirezAlex
Copy link

LGTM

@wesleytodd
Copy link
Member Author

Ok, I think this is the process as documented. I think I just need two thumb's up on one of these comments and I can merge this documentation fix.

antsmartian
antsmartian approved these changes Jan 7, 2020
View reviewed changes
Copy link

@antsmartian antsmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

delvedor
delvedor approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ethan-Arrowood
Ethan-Arrowood approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

raymondfeng
raymondfeng reviewed Jan 7, 2020
View reviewed changes
@wesleytodd wesleytodd merged commit 1202805 into master Jan 7, 2020
@ljharb ljharb deleted the team-goals branch January 7, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondfeng raymondfeng raymondfeng left review comments

@drawm drawm drawm left review comments

@mcollina mcollina mcollina approved these changes

@antsmartian antsmartian antsmartian approved these changes

@fed135 fed135 fed135 approved these changes

@delvedor delvedor delvedor approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@JozefFlakus JozefFlakus JozefFlakus approved these changes

@mhdawson mhdawson mhdawson approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees
No one assigned
Labels
fast-track
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.