GAP | NSFS | Versioning | List Object Version - Always Returns `IsLatest` true

[shirady]

Environment info

• NooBaa Version: current master (5.14)
• Platform: Rancher Desktop 1.19.0 (VM and cluster)

Actual behavior

1. We always return IsLatest true.

Expected behavior

1. Only the latest version should return IsLatest true.

Steps to reproduce

General Settings:

1. Change the configuration of NSFS Versioning to be Enabled in file config.js and change config.NSFS_VERSIONING_ENABLED to true.
2. Deploy noobaa system on minikube (Based on the instructions here - the steps of ‘Build images’ and ‘Deploy noobaa’).
   Note: nb is an alias that runs the local operator from build/_output/bin (alias created by devenv).
3. Deploy NSFS on minikube (Based on the instructions here).

Steps:

5. Enabling versioning
   aws --endpoint-url=https://localhost:12443 --no-verify-ssl s3api put-bucket-versioning --bucket fs1-jenia-bucket --versioning-configuration Status=Enabled
6. Put an object twice
   s3-nb-user-1 aws --endpoint-url=https://localhost:12443 --no-verify-ssl s3api put-object --bucket fs1-jenia-bucket --key fish.txt --body <some_txt_file>
s3-nb-user-1 aws --endpoint-url=https://localhost:12443 --no-verify-ssl s3api put-object --bucket fs1-jenia-bucket --key fish.txt --body <some_txt_file>
7. List object versions:
   aws --endpoint-url=https://localhost:12443 --no-verify-ssl s3api list-object-versions --bucket fs1-jenia-bucket

More information - Screenshots / Logs / Other output

Noobaa output:

AWS output:

[shirady]

@v-harihar knows about this gap, so I edited the title.

[github-actions]

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.

[github-actions]

This issue is stale and had no activity for too long - it will now be closed.

[hseipp]

Please note that in addition to the object versions also multiple delete markers for a single object show IsLatest as true .
After deleting a single object, re-adding a new version and again deleting it:

...
    "DeleteMarkers": [
        {
            "Owner": {
                "DisplayName": "NooBaa",
                "ID": "123"
            },
            "Key": "key1",
            "VersionId": "mtime-d3lql1gt4ruo-ino-t1g",
            "IsLatest": true,
            "LastModified": "2024-08-21T16:39:42+00:00"
        },
        {
            "Owner": {
                "DisplayName": "NooBaa",
                "ID": "123"
            },
            "Key": "key1",
            "VersionId": "mtime-d3lqj85nwwlc-ino-t1e",
            "IsLatest": true,
            "LastModified": "2024-08-21T16:37:19+00:00"
        }
    ],
...

[romayalon]

Closing this issue per Nadav's fix - @nadavMiz @8298