Skip to content

NSFS | NC | fix list-objecs-versions issues #8298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Aug 20, 2024

Explain the changes

  1. change _get_object_list to return version id in suspended mode, causing list-object-versions to return version-id in suspended mode as well
  2. set isLatest flags for objects in the main bucket folder and not in .version
  3. add special case to check if delete marker is the latest version by checking if its the most recent entry of the key

Issues: Fixed #7372

Testing Instructions:

  1. sudo NC_CORETEST=true node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_bucketspace.js
  • Doc added/updated
  • Tests added

@nadavMiz nadavMiz force-pushed the fix-version-list branch 3 times, most recently from 6f00358 to 65b517b Compare August 26, 2024 09:33
@nadavMiz nadavMiz requested a review from romayalon August 26, 2024 10:02
@nadavMiz nadavMiz force-pushed the fix-version-list branch 2 times, most recently from 9a325ab to 294222f Compare August 28, 2024 07:30
@nadavMiz nadavMiz requested a review from romayalon August 28, 2024 07:57
@nadavMiz nadavMiz merged commit 1c8a75f into noobaa:master Aug 29, 2024
10 checks passed
@rkomandu
Copy link
Collaborator

is this backported to 4.17 , in noobaa d/s 0904, this one is still a problem ""IsLatest": true"

@romayalon
Copy link
Contributor

@rkomandu it was backported on 0904, so no, it's not there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GAP | NSFS | Versioning | List Object Version - Always Returns IsLatest true
4 participants