NC | ConfigFS Refactoring #8258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
force-pushed
the
romy-refactor-config-dir
branch
2 times, most recently
from
7e5d01a to
4750d33
Compare
guymguym
reviewed
Aug 6, 2024
2 tasks
romayalon
force-pushed
the
romy-refactor-config-dir
branch
from
de58395 to
2f8b769
Compare
shirady
added a commit
to shirady/noobaa-core
that referenced
this pull request
Aug 6, 2024
As part of adding the class ConfigFS (in PR noobaa#8258) and removing the term global_config in manage_nsfs - since this term was not clear enough and might cause confusion - we will change the constants that had GLOBAL_CONFIG_ as a prefix: 1. rename GLOBAL_CONFIG_ROOT_ALL_FLAG to CLI_MUTUAL_FLAGS 2. rename GLOBAL_CONFIG_ROOT to CONFIG_ROOT_FLAG 3. rename GLOBAL_CONFIG_OPTIONS to CLI_MUTUAL_OPTIONS Signed-off-by: shirady <[email protected]>
guymguym
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
yes, lets start here. this is our "shared library" source dir.
10 tasks
romayalon
force-pushed
the
romy-refactor-config-dir
branch
from
d682a92 to
b4e67ba
Compare
Signed-off-by: Romy <[email protected]>
romayalon
force-pushed
the
romy-refactor-config-dir
branch
from
b4e67ba to
b0e7360
Compare
2 tasks
nimrod-becker
pushed a commit
to nimrod-becker/noobaa-core
that referenced
this pull request
Aug 12, 2024
As part of adding the class ConfigFS (in PR noobaa#8258) and removing the term global_config in manage_nsfs - since this term was not clear enough and might cause confusion - we will change the constants that had GLOBAL_CONFIG_ as a prefix: 1. rename GLOBAL_CONFIG_ROOT_ALL_FLAG to CLI_MUTUAL_FLAGS 2. rename GLOBAL_CONFIG_ROOT to CONFIG_ROOT_FLAG 3. rename GLOBAL_CONFIG_OPTIONS to CLI_MUTUAL_OPTIONS Signed-off-by: shirady <[email protected]> (cherry picked from commit 8c202b4)
dannyzaken
pushed a commit
to dannyzaken/noobaa-core
that referenced
this pull request
Sep 29, 2024
As part of adding the class ConfigFS (in PR noobaa#8258) and removing the term global_config in manage_nsfs - since this term was not clear enough and might cause confusion - we will change the constants that had GLOBAL_CONFIG_ as a prefix: 1. rename GLOBAL_CONFIG_ROOT_ALL_FLAG to CLI_MUTUAL_FLAGS 2. rename GLOBAL_CONFIG_ROOT to CONFIG_ROOT_FLAG 3. rename GLOBAL_CONFIG_OPTIONS to CLI_MUTUAL_OPTIONS Signed-off-by: shirady <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
a. manage_nsfs.js (noobaa-cli) including manage_nsfs_validations.js.
b. bucketspaceFS.js.
c. accountspaceFS.js.
d. Health CLI.
e. NC Bucket Logging CLI.
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: