Skip to content

NC | NSFS | Rename Constants With Prefix GLOBAL_CONFIG #8260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Aug 6, 2024

Explain the changes

As part of adding the class ConfigFS (in PR #8258) and removing the term global_config in manage_nsfs - since this term was not clear enough and might cause confusion - we will change the constants that had GLOBAL_CONFIG_ as a prefix:

  1. rename GLOBAL_CONFIG_ROOT_ALL_FLAG to CLI_MUTUAL_FLAGS
  2. rename GLOBAL_CONFIG_ROOT to CONFIG_ROOT_FLAG
  3. rename GLOBAL_CONFIG_OPTIONS to CLI_MUTUAL_OPTIONS

Issues:

  1. None, it is a small step in the plan that was mentioned in this comment.

Testing Instructions:

  1. None (would be tested in the CI)
  • Doc added/updated
  • Tests added

@shirady shirady changed the title NC | NSFS | Rrename Constants NC | NSFS | Rename Constants With Prefix GLOBAL_CONFIG Aug 6, 2024
@shirady shirady force-pushed the nsfs-nc-rename-constants branch from 2f6a14e to 989233c Compare August 6, 2024 09:14
@shirady shirady requested a review from romayalon August 6, 2024 09:57
@shirady shirady self-assigned this Aug 6, 2024
@romayalon
Copy link
Contributor

@shirady IMO we want to avoid using too general terms like global/general flags/options in CLI context, I would just add CLI_ prefix, WDYT?

@shirady
Copy link
Contributor Author

shirady commented Aug 6, 2024

@shirady IMO we want to avoid using too general terms like global/general flags/options in CLI context, I would just add CLI_ prefix, WDYT?

@romayalon I would accept the suggestion of CLI prefix and add CLI_MUTUAL_ hopefully clearer than the global/general terms.

@shirady shirady force-pushed the nsfs-nc-rename-constants branch from 989233c to 9777e81 Compare August 6, 2024 10:32
As part of adding the class ConfigFS (in PR noobaa#8258) and removing the term global_config in manage_nsfs - since this term was not clear enough and might cause confusion - we will change the constants that had GLOBAL_CONFIG_ as a prefix:
1. rename GLOBAL_CONFIG_ROOT_ALL_FLAG to CLI_MUTUAL_FLAGS
2. rename GLOBAL_CONFIG_ROOT to CONFIG_ROOT_FLAG
3. rename GLOBAL_CONFIG_OPTIONS to CLI_MUTUAL_OPTIONS

Signed-off-by: shirady <[email protected]>
@shirady shirady force-pushed the nsfs-nc-rename-constants branch from 9777e81 to 8c202b4 Compare August 6, 2024 10:57
@shirady shirady merged commit 408c24d into noobaa:master Aug 6, 2024
10 checks passed
@shirady shirady deleted the nsfs-nc-rename-constants branch August 6, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants