Skip to content

NSFS | versioning | don't show .versions folder on list-object-versions #8273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Aug 11, 2024

Explain the changes

  1. change condition in list-object to not add .version folder to common prifixes

Issues: Fixed #xxx / Gap #xxx

  1. NSFS | S3 | Versioning | List objects returns .versions/ folder #8231

Testing Instructions:

  1. sudo node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_bucketspace_versioning.js
  • Doc added/updated
  • Tests added

@nadavMiz nadavMiz requested review from romayalon and vh05 August 11, 2024 11:31
@nadavMiz nadavMiz force-pushed the remove-versions-folder-from-list branch 2 times, most recently from c6dd31a to d1c0003 Compare August 11, 2024 15:25
@nadavMiz nadavMiz force-pushed the remove-versions-folder-from-list branch 2 times, most recently from ebda3ca to 022ea97 Compare August 12, 2024 05:12
@nadavMiz nadavMiz force-pushed the remove-versions-folder-from-list branch from 022ea97 to 5e71305 Compare August 13, 2024 12:07
@nadavMiz nadavMiz merged commit a2992c0 into noobaa:master Aug 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants