reload_git and reload_node_status stack overflow

[jugarpeupv]

Description

If i run Git! pull which is a command available through vim fugitive, then i get this error

Error detected while processing function 26_RunClose[23]..26_RunFinished[12]..fugitive#DidChange[9]..26_DoAutocmdChanged[17]..function 26_RunClose[23]..26_RunFinished[12]..fugitive#DidChange[9]..26_DoAutocmdChanged[10]..User Autocommands for "FugitiveChanged": Error executing lua callback: stack overflow stack traceback: ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:145: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ... ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' ...hare/nvim/lazy/nvim-tree.lua/lua/nvim-tree/node/init.lua:150: in function 'reload_node_status' .../nvim/lazy/nvim-tree.lua/lua/nvim-tree/explorer/init.lua:371: in function 'reload_git' ...a/.local/share/nvim/lazy/nvim-tree.lua/lua/nvim-tree.lua:255: in function <...a/.local/share/nvim/lazy/nvim-tree.lua/lua/nvim-tree.lua:251>

If i point nvim-tree to commit = "517e4fbb9ef3c0986da7047f44b4b91a2400f93c" it does not break

I think the issue is related to this #2930

Neovim version

NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1724512491
Run "nvim -V1 -v" for more info

Operating system and version

macOs

Windows variant

No response

nvim-tree version

main

Clean room replication

**

Steps to reproduce

Git! pull

Expected behavior

Reload properly

Actual behavior

Error

[gegoune]

Please follow all instructions as outlined in https://github.com/nvim-tree/nvim-tree.lua/issues/new?assignees=&labels=bug&projects=&template=bug_report.yml.

[alex-courtis]

This was refactored yesterday via #2916

Reverted.

[alex-courtis]

@jugarpeupv please do raise an issue as described above, so that we may fix and proceed with the reverted change.

[alex-courtis]

Replicated, occurs only when watchers disabled or Api.git.reload