Skip to content

refactor(#2871, #2886): multi instance: node classes created #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Oct 7, 2024
Merged

refactor(#2871, #2886): multi instance: node classes created #2916

merged 44 commits into from
Oct 7, 2024

Conversation

alex-courtis
Copy link
Member

@alex-courtis alex-courtis commented Sep 16, 2024 •
edited
Loading

Base automatically changed from multiinstance-renderer to master September 21, 2024 00:41
@alex-courtis alex-courtis force-pushed the node-classes branch 2 times, most recently from 6305335 to 8ceccd1 Compare September 22, 2024 05:36
@alex-courtis alex-courtis mentioned this pull request Sep 23, 2024
Open
@alex-courtis alex-courtis force-pushed the node-classes branch 2 times, most recently from 379304b to 0979136 Compare September 30, 2024 01:24
@alex-courtis
refactor(#2875): multi instance renderer
71c519b
@alex-courtis
refactor(#2875): multi instance renderer
760b1bc
@alex-courtis
refactor(#2875): multi instance renderer
2ce5f69
@alex-courtis
refactor(#2875): multi instance renderer
15e65ea
@alex-courtis
node classes and constructors
646ce63
@alex-courtis
node methods
9193ec9
@alex-courtis
refactor(#2875): multi instance renderer
d3946a1
@alex-courtis
node classes and constructors
69663ff
@alex-courtis
explorer is a directory node
5ae0a90
@alex-courtis
extract methods from explore_node
0f222ff
@alex-courtis
extract methods from explore_node
f5f58ff
@alex-courtis
extract methods from explore_node
d097705
@alex-courtis
extract methods from lib
16bbe89
@alex-courtis
use .. name for root node for compatibility
91f477d
@alex-courtis
use node.explorer
6c274dd
@alex-courtis
extract node factory, remove unused code
739d1e4
@alex-courtis
factories for all nodes, add RootNode
b1d9655
@alex-courtis
factories for all nodes, add RootNode
47b1ccb
@alex-courtis
use factory pattern for decorators
32431b6
@alex-courtis
note regression and commit
102847d
@alex-courtis
fix dir git status regression
e5d96f0
@alex-courtis
destroy nodes, not explorer
abc21e0
@alex-courtis
add BaseNode:is
2e1cc1a
@alex-courtis
revert changes to create-file, handle in #2924
5a863b2
@alex-courtis alex-courtis changed the title refactor(#2871, #2886): node classes with explorer back references refactor(#2871, #2886): node classes Oct 5, 2024
@alex-courtis alex-courtis changed the title refactor(#2871, #2886): node classes refactor(#2871, #2886): node classes created Oct 7, 2024
@alex-courtis alex-courtis changed the title refactor(#2871, #2886): node classes created refactor(#2871, #2886): multi instance: node classes created Oct 7, 2024
@alex-courtis alex-courtis merged commit 38aac09 into master Oct 7, 2024
7 checks passed
@alex-courtis alex-courtis deleted the node-classes branch October 7, 2024 02:46
@alex-courtis alex-courtis mentioned this pull request Oct 7, 2024
Closed
alex-courtis added a commit that referenced this pull request Oct 8, 2024
@alex-courtis
Revert "refactor(#2871, #2886): multi instance: node classes created (#…
50e9194 
…2916)"

This reverts commit 38aac09.
@alex-courtis alex-courtis mentioned this pull request Oct 8, 2024
Closed
@alex-courtis
Copy link
Member Author

Reverted: #2945

@alex-courtis alex-courtis mentioned this pull request Oct 11, 2024
Closed
alex-courtis added a commit that referenced this pull request Oct 11, 2024
@alex-courtis
Reapply "refactor(#2871, #2886): multi instance: node classes created (…
751410b 
…#2916)"

This reverts commit 50e9194.
@alex-courtis alex-courtis mentioned this pull request Oct 11, 2024
Merged
alex-courtis added a commit that referenced this pull request Oct 11, 2024
@alex-courtis
fix(#2945): stack overflow on api.git.reload or fugitive event with w…
5ad8762 
…atchers disabled (#2949)

* Reapply "refactor(#2871, #2886): multi instance: node classes created (#2916)"

This reverts commit 50e9194.

* fix(#2945): stack overflow on api.git.reload or fugitive event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi Instance: Refactor: Node Back References To Explorer
1 participant
@alex-courtis