Skip to content

bug(#4241): enable SnippetIT, ReadmeSnippetsIT#4255

Merged
yegor256 merged 1 commit into
objectionary:masterfrom
h1alexbel:4241
Jun 6, 2025
Merged

bug(#4241): enable SnippetIT, ReadmeSnippetsIT#4255
yegor256 merged 1 commit into
objectionary:masterfrom
h1alexbel:4241

Conversation

@h1alexbel

@h1alexbel h1alexbel commented Jun 6, 2025

Copy link
Copy Markdown
Member

In this pull I've enabled both SnippetIT and ReadmeSnippetsIT, since we released new version of EO-runtime: 0.56.4.

closes #4241

Summary by CodeRabbit

  • Tests
    • Enabled additional integration tests that were previously skipped.

@coderabbitai

coderabbitai Bot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The changes remove the @Disabled annotation from two integration test classes, ReadmeSnippetsIT and SnippetIT, enabling these tests to run. Additionally, a related todo comment is deleted from SnippetIT. No other modifications are made to the test logic or structure.

Changes

Files Change Summary
eo-integration-tests/src/test/java/integration/ReadmeSnippetsIT.java Removed @Disabled annotation to enable test execution.
eo-integration-tests/src/test/java/integration/SnippetIT.java Removed @Disabled annotation and deleted related comment.

Assessment against linked issues

Objective Addressed Explanation
Enable integration tests in SnippetIT.java by removing @Disabled and deleting the puzzle comment (#4241)

Poem

The tests once slept in silent night,
Now woken up to run their flight.
With puzzles gone and code in tune,
They leap like rabbits past the moon.
🐇✨

Integration dreams, now set free—
Hopping onward, joyfully!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d59ee3 and 4df125e.

📒 Files selected for processing (2)
  • eo-integration-tests/src/test/java/integration/ReadmeSnippetsIT.java (0 hunks)
  • eo-integration-tests/src/test/java/integration/SnippetIT.java (0 hunks)
💤 Files with no reviewable changes (2)
  • eo-integration-tests/src/test/java/integration/SnippetIT.java
  • eo-integration-tests/src/test/java/integration/ReadmeSnippetsIT.java
⏰ Context from checks skipped due to timeout of 90000ms (13)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: snippets
  • GitHub Check: benchmark
  • GitHub Check: ebnf
  • GitHub Check: ort
  • GitHub Check: integration
  • GitHub Check: trufflehog
  • GitHub Check: mvn (macos-15, 23)
  • GitHub Check: mvn (ubuntu-24.04, 11)
  • GitHub Check: mvn (windows-2022, 23)
  • GitHub Check: qulice
  • GitHub Check: mvn (ubuntu-24.04, 23)
  • GitHub Check: pdd
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@h1alexbel h1alexbel changed the title bug(#4241): enable SnippetIT, ReadmeSnippetsIT bug(#4241): enable SnippetIT, ReadmeSnippetsIT Jun 6, 2025
@github-actions

github-actions Bot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

All benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information.

Click to see the detailed report
Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 151.242 162.874 11.631 7.69% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 144.462 137.351 -7.111 -4.92% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 170.935 146.073 -24.861 -14.54% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 11.631 ms/op (7.69%)
✅ Performance gain: benchmarks.XmirBench.xmirToPhi is faster by 7.111 ms/op (4.92%)
✅ Performance gain: benchmarks.XmirBench.xmirToSaltyPhi is faster by 24.861 ms/op (14.54%)

@h1alexbel

Copy link
Copy Markdown
Member Author

@maxonfjvipon please check

@h1alexbel

Copy link
Copy Markdown
Member Author

@yegor256 take a look, please

@yegor256 yegor256 added this pull request to the merge queue Jun 6, 2025
Merged via the queue into objectionary:master with commit 589101a Jun 6, 2025
27 checks passed
@h1alexbel h1alexbel deleted the 4241 branch June 6, 2025 16:03
@0crat

0crat commented Jun 7, 2025

Copy link
Copy Markdown

@maxonfjvipon Great job on the review! 🌟 You've earned +4 points, which includes a +12 base, adjustments for comments and hits-of-code, and a +16 bonus. Keep up the good work and aim for more comments and code contributions next time. Your current balance is -202. Let's push for improvement!

@0crat

0crat commented Jun 7, 2025

Copy link
Copy Markdown

@yegor256 Thanks for your code review! Here's how your +4 points were calculated: +12 base points, -16 for no comments, -8 for only 8 hits-of-code (below the 16 threshold), and +16 to meet the minimum 4-point reward. Remember, more comments and hits-of-code can boost your future rewards! Your current balance is -254. Keep up the good work! 💻

@0crat

0crat commented Jun 7, 2025

Copy link
Copy Markdown

@h1alexbel Hey there! 👋 Nice work on your contribution! You've snagged 8 points for this one. Here's the breakdown: you got the base 16 points, but we had to deduct 8 because the hits-of-code were a bit low (only 8). Remember, we're aiming for at least 20 hits-of-code to avoid that deduction. Keep the code flowing – quality and speed are both key! Your total balance is now sitting pretty at +442. Looking forward to your next contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration Tests in SnippetIT.java Not Enabled after Recent Update

4 participants