Skip to content

bug(#4630): enable integration tests after compact package names release#4634

Merged
yegor256 merged 2 commits into
objectionary:masterfrom
h1alexbel:4630
Oct 17, 2025
Merged

bug(#4630): enable integration tests after compact package names release#4634
yegor256 merged 2 commits into
objectionary:masterfrom
h1alexbel:4630

Conversation

@h1alexbel

@h1alexbel h1alexbel commented Oct 17, 2025

Copy link
Copy Markdown
Member

In this PR I've enabled tests that depends on new compact package names, that were released in 0.59.0.

closes #4630

Summary by CodeRabbit

  • Tests
    • Re-enabled integration tests for JAR execution, README examples, and code snippets.
    • Updated test expectations for object reference names.

@coderabbitai

coderabbitai Bot commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request re-enables three previously disabled integration tests by removing @disabled annotations and their imports. Additionally, test expectations in OyRemoteTest are updated to reflect different EO object directory names.

Changes

Cohort / File(s) Summary
Re-enabled Integration Tests
eo-integration-tests/src/test/java/integration/JarIT.java, eo-integration-tests/src/test/java/integration/ReadmeSnippetsIT.java, eo-integration-tests/src/test/java/integration/SnippetIT.java
Removed @Disabled annotations and corresponding imports to enable previously skipped tests. No changes to test logic or helper methods.
Updated Test Expectations
eo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.java
Updated expected EO object directory names in test assertions: "org.eolang.math" → "org.eolang.ms" and "org.eolang.structs" → "org.eolang.ss".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • maxonfjvipon
  • yegor256

Poem

🐰 The tests were sleeping in the dark,
But now they hop back with a spark!
Disabled flags are swept away,
Let's verify our code today! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "bug(#4630): enable integration tests after compact package names release" accurately reflects the main changes in the changeset. The title clearly indicates the primary action (enabling integration tests) and provides relevant context (the reason is the compact package names release). The title is concise, specific enough for someone scanning the repository history to understand the purpose, and directly maps to the core changes shown in the raw summary: removal of @disabled annotations across multiple test files and updates to test expectations for the new package naming scheme.
Linked Issues Check ✅ Passed The changes align with the primary requirement from issue #4630. The PR removes @disabled annotations from JarIT.java (along with the org.junit.jupiter.api.Disabled import) and shortens the JavaDoc deprecation notes, which addresses the puzzle resolution requirement. Additionally, the changes to OyRemoteTest.java update expected package names from the older format (org.eolang.math, org.eolang.structs) to the new compact format (org.eolang.ms, org.eolang.ss), properly adapting tests to work with version 0.59.0's compact package names release. The related test files (ReadmeSnippetsIT.java and SnippetIT.java) also have @disabled annotations removed, which completes the objective of enabling integration tests across the test suite.
Out of Scope Changes Check ✅ Passed All changes in the pull request are directly aligned with the stated objectives. The removal of @disabled annotations from JarIT.java, ReadmeSnippetsIT.java, and SnippetIT.java directly enables the previously disabled integration tests. The removal of corresponding imports represents necessary cleanup. The updates to OyRemoteTest.java expectations (changing expected package names to their compact equivalents) are essential for tests to pass with the new package naming scheme introduced in version 0.59.0. No unrelated refactoring, bug fixes, or feature additions are present.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
eo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.java (1)

120-134: ✓ Update is correct; consider renaming variable for clarity.

The directory name has been correctly updated from what was org.eolang.structs to org.eolang.ss to align with the compact package names. However, the variable on Line 121 is named stdout, which is misleading since it holds a directory name, not a stdout program reference. Compare this to Line 103 in checksPresenceOfProgramWithNarrowHash() where stdout appropriately holds "org.eolang.io.stdout".

Consider renaming the variable for clarity:

-        final String stdout = "org.eolang.ss";
+        final String directory = "org.eolang.ss";
         MatcherAssert.assertThat(
             String.format(
-                "OyRemote with narrow hash should have contained directory %s, but it didn't",
-                stdout
+                "OyRemote with narrow hash should have contained directory %s, but it didn't",
+                directory
             ),
             new OyRemote(
                 new ChNarrow(
                     new ChRemote("master")
                 )
-            ).contains(stdout),
+            ).contains(directory),
             Matchers.is(true)
         );
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b971c20 and a8ceebc.

📒 Files selected for processing (4)
  • eo-integration-tests/src/test/java/integration/JarIT.java (0 hunks)
  • eo-integration-tests/src/test/java/integration/ReadmeSnippetsIT.java (0 hunks)
  • eo-integration-tests/src/test/java/integration/SnippetIT.java (0 hunks)
  • eo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.java (2 hunks)
💤 Files with no reviewable changes (3)
  • eo-integration-tests/src/test/java/integration/SnippetIT.java
  • eo-integration-tests/src/test/java/integration/ReadmeSnippetsIT.java
  • eo-integration-tests/src/test/java/integration/JarIT.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: trufflehog
  • GitHub Check: integration
  • GitHub Check: ort
  • GitHub Check: qulice
  • GitHub Check: benchmark
  • GitHub Check: snippets
  • GitHub Check: mvn (ubuntu-24.04, 17)
  • GitHub Check: mvn (ubuntu-24.04, 23)
  • GitHub Check: mvn (windows-2022, 23)
  • GitHub Check: mvn (macos-15, 23)
🔇 Additional comments (1)
eo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.java (1)

90-98: ✓ Correct package name update for compact naming convention.

The directory name has been correctly updated from org.eolang.math to org.eolang.ms to align with the compact package names introduced in v0.59.0.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

All benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information.

Click to see the detailed report
Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 199.049 204.145 5.096 2.56% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 5.096 ms/op (2.56%)

@h1alexbel

Copy link
Copy Markdown
Member Author

@yegor256 please check

@yegor256 yegor256 merged commit 602a65e into objectionary:master Oct 17, 2025
26 checks passed
@h1alexbel h1alexbel deleted the 4630 branch October 17, 2025 11:28
@0crat

0crat commented Nov 8, 2025

Copy link
Copy Markdown

@h1alexbel Great work on your contribution! 🎉 You've earned +12 points (+16 base, -4 for 15 hits-of-code). Keep up the momentum with quality contributions! Your score is now +196 – check your Zerocracy account for updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JarIT#runsProgramFromJar Functionality Disabled and Needs Enabling

3 participants