bug(#4630): enable integration tests after compact package names release#4634
Conversation
WalkthroughThis pull request re-enables three previously disabled integration tests by removing @disabled annotations and their imports. Additionally, test expectations in OyRemoteTest are updated to reflect different EO object directory names. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
eo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.java (1)
120-134: ✓ Update is correct; consider renaming variable for clarity.The directory name has been correctly updated from what was
org.eolang.structstoorg.eolang.ssto align with the compact package names. However, the variable on Line 121 is namedstdout, which is misleading since it holds a directory name, not a stdout program reference. Compare this to Line 103 inchecksPresenceOfProgramWithNarrowHash()wherestdoutappropriately holds"org.eolang.io.stdout".Consider renaming the variable for clarity:
- final String stdout = "org.eolang.ss"; + final String directory = "org.eolang.ss"; MatcherAssert.assertThat( String.format( - "OyRemote with narrow hash should have contained directory %s, but it didn't", - stdout + "OyRemote with narrow hash should have contained directory %s, but it didn't", + directory ), new OyRemote( new ChNarrow( new ChRemote("master") ) - ).contains(stdout), + ).contains(directory), Matchers.is(true) );
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
eo-integration-tests/src/test/java/integration/JarIT.java(0 hunks)eo-integration-tests/src/test/java/integration/ReadmeSnippetsIT.java(0 hunks)eo-integration-tests/src/test/java/integration/SnippetIT.java(0 hunks)eo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.java(2 hunks)
💤 Files with no reviewable changes (3)
- eo-integration-tests/src/test/java/integration/SnippetIT.java
- eo-integration-tests/src/test/java/integration/ReadmeSnippetsIT.java
- eo-integration-tests/src/test/java/integration/JarIT.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: trufflehog
- GitHub Check: integration
- GitHub Check: ort
- GitHub Check: qulice
- GitHub Check: benchmark
- GitHub Check: snippets
- GitHub Check: mvn (ubuntu-24.04, 17)
- GitHub Check: mvn (ubuntu-24.04, 23)
- GitHub Check: mvn (windows-2022, 23)
- GitHub Check: mvn (macos-15, 23)
🔇 Additional comments (1)
eo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.java (1)
90-98: ✓ Correct package name update for compact naming convention.The directory name has been correctly updated from
org.eolang.mathtoorg.eolang.msto align with the compact package names introduced in v0.59.0.
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
|
|
@yegor256 please check |
|
@h1alexbel Great work on your contribution! 🎉 You've earned +12 points (+16 base, -4 for 15 hits-of-code). Keep up the momentum with quality contributions! Your score is now +196 – check your Zerocracy account for updates. |
In this PR I've enabled tests that depends on new compact package names, that were released in 0.59.0.
closes #4630
Summary by CodeRabbit