bug(#4987): fixed classedDir in MjSafe#4988
Merged
yegor256 merged 1 commit intoApr 16, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR adjusts Maven plugin default parameters, updates test configurations and assertions to use shortened object paths (from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
eo-integration-tests/src/test/java/integration/JarIT.java (1)
29-31: Minor formatting issue in the TODO link.The URL
https://github.com/objectionary/eo/issues/4987?issue=objectionary%7Ceo%7C4538appears to have an unusual query parameter (?issue=objectionary|eo|4538). The standard GitHub issue URL format ishttps://github.com/objectionary/eo/issues/4987. The extra query parameter may be a copy-paste artifact and could cause confusion.🔧 Suggested fix
-* `@todo` `#4987`:30min Enable JarIt integration tests. The tests were disabled because of this ticket: -* https://github.com/objectionary/eo/issues/4987?issue=objectionary%7Ceo%7C4538. When new release +* `@todo` `#4987`:30min Enable JarIt integration tests. The tests were disabled because of this ticket: +* https://github.com/objectionary/eo/issues/4987. When new release🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@eo-integration-tests/src/test/java/integration/JarIT.java` around lines 29 - 31, Fix the formatting of the TODO comment in JarIT.java: update the URL in the puzzle comment that currently reads "https://github.com/objectionary/eo/issues/4987?issue=objectionary%7Ceo%7C4538" to the standard GitHub issue URL "https://github.com/objectionary/eo/issues/4987" (remove the extraneous "?issue=..." query parameter) so the `@todo/`#4987 comment references the canonical issue link.eo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.java (1)
116-130: Misleading variable name:stdoutholds a directory path"ss".The variable is named
stdoutbut contains"ss", which represents a directory being tested. Consider renaming to something likedirectoryordirPathto match the test's purpose (checking presence of a directory with narrow hash).✏️ Suggested rename for clarity
`@Test` `@ExtendWith`(WeAreOnline.class) void checksPresenceOfDirectoryWithNarrowHash() throws IOException { - final String stdout = "ss"; + final String directory = "ss"; MatcherAssert.assertThat( String.format( - "OyRemote with narrow hash should have contained directory %s, but it didn't", - stdout + "OyRemote with narrow hash should have contained directory %s, but it didn't", + directory ), new OyRemote( new ChNarrow( new ChRemote("master") ) - ).contains(stdout), + ).contains(directory), Matchers.is(true) ); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@eo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.java` around lines 116 - 130, Rename the misleading variable stdout in the test method checksPresenceOfDirectoryWithNarrowHash to a name that reflects a directory path (e.g., directory or dirPath); update its declaration and all uses in the assertion String.format and the OyRemote.contains call so the test remains functionally identical (references: method checksPresenceOfDirectoryWithNarrowHash, variable stdout -> directory/dirPath, classes OyRemote, ChNarrow, ChRemote).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@eo-integration-tests/src/test/java/integration/JarIT.java`:
- Around line 29-31: Fix the formatting of the TODO comment in JarIT.java:
update the URL in the puzzle comment that currently reads
"https://github.com/objectionary/eo/issues/4987?issue=objectionary%7Ceo%7C4538"
to the standard GitHub issue URL
"https://github.com/objectionary/eo/issues/4987" (remove the extraneous
"?issue=..." query parameter) so the `@todo/`#4987 comment references the
canonical issue link.
In `@eo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.java`:
- Around line 116-130: Rename the misleading variable stdout in the test method
checksPresenceOfDirectoryWithNarrowHash to a name that reflects a directory path
(e.g., directory or dirPath); update its declaration and all uses in the
assertion String.format and the OyRemote.contains call so the test remains
functionally identical (references: method
checksPresenceOfDirectoryWithNarrowHash, variable stdout -> directory/dirPath,
classes OyRemote, ChNarrow, ChRemote).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cdd9b2c8-25ee-4c9d-b323-8d31177afb35
📒 Files selected for processing (7)
eo-integration-tests/src/test/java/integration/JarIT.javaeo-maven-plugin/src/main/java/org/eolang/maven/MjSafe.javaeo-maven-plugin/src/test/java/org/eolang/maven/MjUnspileTest.javaeo-maven-plugin/src/test/java/org/eolang/maven/ObjectsIndexTest.javaeo-maven-plugin/src/test/java/org/eolang/maven/OyIndexedTest.javaeo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.javaeo-runtime/pom.xml
Member
Author
|
@yegor256 please check |
Member
|
@maxonfjvipon I'm getting the following errors locally: Will this PR solve them? |
Member
Author
|
@maxonfjvipon Great work on your contribution! 🎉 You've earned +12 points (+16 base, -4 for 187 hits-of-code exceeding our 100 limit). Your total score is now +60 - keep the momentum going and don't forget to check your Zerocracy account for updates! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4987
Summary by CodeRabbit
Release Notes
Tests
Chores