Skip to content

sidebar backdrop #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbostock merged 4 commits into from
Nov 29, 2023
Merged

sidebar backdrop #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
223a48b
sidebar backdrop
mbostock Nov 29, 2023
0a3ae45
Merge branch 'main' into mbostock/sidebar-backdrop
Fil Nov 29, 2023
e8cf4f8
Merge branch 'main' into mbostock/sidebar-backdrop
Fil Nov 29, 2023
08bd2d0
hide backdrop when the page is large enough
Fil Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions public/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ body {
font: 14px var(--sans-serif);
font-weight: 500;
width: 240px;
z-index: 1;
z-index: 2;
top: 0;
bottom: 0;
left: calc(-240px - 2rem);
Expand Down Expand Up @@ -199,7 +199,7 @@ body {
margin: 0;
padding: 2px;
cursor: pointer;
z-index: 2;
z-index: 3;
background: none;
color: var(--theme-foreground-muted);
font-weight: 700;
Expand Down Expand Up @@ -296,7 +296,7 @@ a[href],
color: var(--theme-foreground-focus);
}

#observablehq-sidebar-toggle:checked + #observablehq-sidebar {
#observablehq-sidebar-toggle:checked ~ #observablehq-sidebar {
left: 0;
box-shadow: 0 0 8px 4px rgba(0, 0, 0, 0.1);
}
Expand All @@ -305,8 +305,22 @@ a[href],
transition: left 150ms ease;
}

#observablehq-sidebar-backdrop {
display: none;
position: fixed;
top: 0;
right: 0;
bottom: 0;
left: 0;
z-index: 2;
}

#observablehq-sidebar-toggle:checked ~ #observablehq-sidebar-backdrop {
display: initial;
}

@media (prefers-color-scheme: dark) {
#observablehq-sidebar-toggle:checked + #observablehq-sidebar {
#observablehq-sidebar-toggle:checked ~ #observablehq-sidebar {
box-shadow: 0 0 8px 4px rgba(0, 0, 0, 0.5);
}
}
Expand All @@ -318,8 +332,11 @@ a[href],
#observablehq-sidebar-toggle:indeterminate::before {
content: "⟨";
}
#observablehq-sidebar-toggle:checked + #observablehq-sidebar,
#observablehq-sidebar-toggle:indeterminate + #observablehq-sidebar {
#observablehq-sidebar-backdrop {
display: none;
}
#observablehq-sidebar-toggle:checked ~ #observablehq-sidebar,
#observablehq-sidebar-toggle:indeterminate ~ #observablehq-sidebar {
left: 0;
box-shadow: none;
}
Expand All @@ -328,6 +345,9 @@ a[href],
padding-left: calc(240px + 3rem);
padding-right: 1rem;
}
#observablehq-sidebar-toggle:checked ~ #observablehq-sidebar-backdrop {
display: none;
}
pre {
border-radius: 4px;
}
Expand Down
1 change: 1 addition & 0 deletions src/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ ${renderFooter(path, options)}

function renderSidebar(title = "Home", pages: (Page | Section)[], path: string): Html {
return html`<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link${path === "/index" ? " observablehq-link-active" : ""}"><a href="${relativeUrl(
Expand Down
1 change: 1 addition & 0 deletions test/output/build/archives/tar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link"><a href="./">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/archives/zip.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link"><a href="./">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/config/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link observablehq-link-active"><a href="./">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/config/one.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link"><a href="./">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/config/sub/two.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link"><a href="../">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/config/toc-override.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link"><a href="./">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/config/toc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link"><a href="./">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/files/files.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link"><a href="./">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/files/subsection/subfiles.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link"><a href="../">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/imports/foo/foo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link"><a href="../">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/missing-file/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link observablehq-link-active"><a href="./">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/missing-import/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link observablehq-link-active"><a href="./">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/multi/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link observablehq-link-active"><a href="./">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/multi/subsection/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link"><a href="../">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/simple-public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link observablehq-link-active"><a href="./">Home</a></li>
Expand Down
1 change: 1 addition & 0 deletions test/output/build/simple/simple.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

</script>
<input id="observablehq-sidebar-toggle" type="checkbox">
<label id="observablehq-sidebar-backdrop" for="observablehq-sidebar-toggle"></label>
<nav id="observablehq-sidebar">
<ol>
<li class="observablehq-link"><a href="./">Home</a></li>
Expand Down