Conversation
mbostock
force-pushed
the
mbostock/sidebar-backdrop
branch
from
dbb5802 to
6e141d8
Compare
mbostock
force-pushed
the
mbostock/sidebar-backdrop
branch
from
6e141d8 to
223a48b
Compare
Addresses the following scenario: the user starts on a small window, types cmd-B to show the sidebar, then enlarges the window to read the contents, and wants to click on a link. If we didn't hide the backdrop, the click would close the sidebar and move the contents to the left.
Contributor
|
Fixed a small bug in the following scenario: the user starts on a small window, types cmd-B to show the sidebar, then enlarges the window to read the contents, and wants to click on a link.The click would close the sidebar and move the contents to the left. |
Fil
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #208. Adds a new backdrop that appears on small screens when the sidebar is floating; clicking it dismisses the sidebar. I experimented with using backdrop-filter: blur and a partially transparent background-color on the backdrop, but I think it looks better with no visual effect… especially since the page is still scrollable when the floating sidebar is open.