add grid class documentation #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i've updated the example code to match the style in #561 now looks like:
|
Fil
requested changes
Jan 18, 2024
docs/layout/grid.md
Outdated
|
|
||
| To see these examples change dynamically, adjust the page width or collapse the sidebar on the left. | ||
|
|
||
| As with any CSS provided by the CLI, you can mix in standard CSS to customize pages. |
There was a problem hiding this comment.
I'm not sure I understand this sentence (or its purpose).
There was a problem hiding this comment.
you've highlighted two sentences here, i assume you are referring to the second sentence. my intent there is to highlight to novice users that they are not limited to the css classes we provide, but now that you mention it, it does seem unnecessary. i have removed it. :)
the first sentence is for folks with narrow screens who might not see 4 column grids as 4 columns without hiding the sidebar.
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
allisonhorst
approved these changes
Jan 18, 2024
|
@Fil i'm merging this up into components so you will have another crack at there as that PR lands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add documentation for the grid CSS classes. i'm not sure if we want to use the js echo for the example code.
i worry that that it will nudge them to use the hypertext literal when they might not need to. i could duplicate the example code into fenced blocks and not use echo, but then we have two copies of the code.
here is how the full page renders.