-
Notifications
You must be signed in to change notification settings - Fork 154
Cards #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cards #561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing but the smallest of nits! looks great!
Co-authored-by: Robert Harris <[email protected]> Co-authored-by: Cindy <[email protected]>
width quotes Co-authored-by: Robert Harris <[email protected]>
docs/layout/card.md
Outdated
${ | ||
Plot.plot({ | ||
marks: [ | ||
Plot.cell(weather, {x: d => d.date.getUTCDate(), y: d => d.date.getUTCMonth(),fill: "temp_max"}) | ||
] | ||
}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${ | |
Plot.plot({ | |
marks: [ | |
Plot.cell(weather, {x: d => d.date.getUTCDate(), y: d => d.date.getUTCMonth(),fill: "temp_max"}) | |
] | |
}) | |
} | |
${ | |
Plot.plot({ | |
marks: [ | |
Plot.cell(weather, {x: d => d.date.getUTCDate(), y: d => d.date.getUTCMonth(),fill: "temp_max"}) | |
] | |
}) | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a few more places with the div/ template literal indents, but otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few small changes
Co-authored-by: Philippe Rivière <[email protected]>
First pass at adding layout/cards.md, introducing
card
class (mainly through examples)Includes:
What is missing that we want to include?
TODO: resize on card content?