Skip to content

Cards #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 18, 2024
Merged

Cards #561

merged 14 commits into from
Jan 18, 2024

Conversation

allisonhorst
Copy link
Contributor

First pass at adding layout/cards.md, introducing card class (mainly through examples)

Includes:

  • Card content (showing that card content can be anything - images, charts, text, an input + table, etc.)
  • Title and subtitle
  • Content outside of cards

What is missing that we want to include?

TODO: resize on card content?

@allisonhorst allisonhorst requested review from Fil, trebor and cinxmo January 18, 2024 00:44
Copy link
Contributor

@trebor trebor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing but the smallest of nits! looks great!

allisonhorst and others added 2 commits January 17, 2024 18:37
Co-authored-by: Robert Harris <[email protected]>
Co-authored-by: Cindy <[email protected]>
width quotes

Co-authored-by: Robert Harris <[email protected]>
Comment on lines 21 to 27
${
Plot.plot({
marks: [
Plot.cell(weather, {x: d => d.date.getUTCDate(), y: d => d.date.getUTCMonth(),fill: "temp_max"})
]
})
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
${
Plot.plot({
marks: [
Plot.cell(weather, {x: d => d.date.getUTCDate(), y: d => d.date.getUTCMonth(),fill: "temp_max"})
]
})
}
${
Plot.plot({
marks: [
Plot.cell(weather, {x: d => d.date.getUTCDate(), y: d => d.date.getUTCMonth(),fill: "temp_max"})
]
})
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few more places with the div/ template literal indents, but otherwise looks good!

@allisonhorst allisonhorst mentioned this pull request Jan 18, 2024
9 tasks
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small changes

Co-authored-by: Philippe Rivière <[email protected]>
@allisonhorst allisonhorst merged commit 4fa1abc into components Jan 18, 2024
@allisonhorst allisonhorst deleted the allison/cards branch January 18, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants