-
Notifications
You must be signed in to change notification settings - Fork 185
className option for marks #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Going to take a first stab at this |
This would make my life a lot easier - when you have to do something outside the bounds of plot, being able to specify a class name would be a big help |
I can try to have a pull request up this weekend @llimllib, been meaning to do this |
This functionality would be an excellent addition. Are there any updates on the progress? It looks like there is a PR, but it hasn't been updated in some time. |
Adding support for this issue—I want to further describe a few scenarios where I found custom styling particularly important:
We benefit greatly from the capabilities and convenience of Plot. That said, our current solution around these styling issues is partly hacking CSS and partly rewriting some observable visual elements (especially inputs). I'd love to stop doing those two things and stick closer to the vanilla Plot throughout the prototyping to production pipeline. |
className should be optional and have no default value, so you have to decide what names you want to use and there are no implicit classes
Related: #253 #6 #126 #490
(Note: for the general plot there is already a top-level className; we'd initially want this only for marks.)
The text was updated successfully, but these errors were encountered: