Skip to content

className option for plot, facets, axes and marks #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Mar 18, 2021

@Fil Fil requested a review from mbostock March 18, 2021 15:26
@Fil Fil mentioned this pull request Mar 18, 2021
@Fil Fil mentioned this pull request May 12, 2021
@Fil
Copy link
Contributor Author

Fil commented Jul 27, 2021

https://observablehq.com/@mcmcclur/a-plot-selection-hack by @mcmcclur also wants class names, though it's not totally clear to me if this pull-request corresponds to Mark's use-case.

@Fil
Copy link
Contributor Author

Fil commented Mar 23, 2022

if there is interest, we should redo this as a common style (#490)

@Fil Fil closed this Mar 23, 2022
@Fil Fil deleted the markclass2 branch March 23, 2022 16:02
@RLesser
Copy link
Contributor

RLesser commented Jul 20, 2022

Is there an issue for this beyond this pull request? Happy to make one if not or just start another pull request for className implemented as a common style. I'd find it fairly useful in the scenarios where I have multiple mark groups of the same type, and want to reference only one of them in post processing without relying on the order of the marks and filter statements.

@Fil Fil mentioned this pull request Jul 20, 2022
@Fil
Copy link
Contributor Author

Fil commented Jul 20, 2022

@RLesser There wasn't, I've opened #1002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants