inline styles; tabular nums #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/inline-styles
branch
from
dc6feed to
822aebf
Compare
|
Related: #253 lets the user set the plot's class name. I don't love the call to Math.random but I guess there's no other way to scope this :-/ |
Merged
* keep inline stylesheet * inline stylesheets
* keep inline stylesheet * inline stylesheets * top-level className * coerce className to string Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlines the stylesheet into the SVG element. Fixes #578. This was carefully designed so that you can still specify inline styles via the style option which override the default styles. Also, it ensures that any other elements on the page that happen to have the class “plot” are no longer affected by Plot’s global styles.
The text white-space: pre style is tricky. I would rather define this on the SVG attribute, but the user agent style sheet will override it with white-space: nowrap if I do. So the only way to do this (without manually setting the style on every text element that Plot creates, including those inside D3 axes) is with a selector.
Also adds font-variant: tabular-nums. Fixes #577.