Skip to content

Auto mark passes through other options to mark #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tophtucker
Copy link
Contributor

@tophtucker tophtucker commented Feb 6, 2023

Part of #1252

@tophtucker tophtucker requested review from Fil and mbostock February 6, 2023 18:02
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this is what I was imagining. But I think we need to give this some more thought. For example, what happens if you specify the fill or stroke option? Should those be ignored? Should they only be ignored if you specify the color option? Or should they take precedence over color? Etc.

I think first we should survey the standard mark options, as well as the options that are potentially supported by all the mark types that are eligible for use by the auto mark (which is arguably all of ’em) and see if there are any weirdnesses.

The other big question is whether these should go into the transformOptions i.e. before the transform is invoked, so that e.g. you can specify the number of thresholds you want for the bin transform, rather than doing it after the transform and only passing it directly to the mark.

@mbostock mbostock mentioned this pull request Feb 6, 2023
13 tasks
@mbostock mbostock mentioned this pull request Feb 15, 2023
@tophtucker
Copy link
Contributor Author

Stale, too naive an approach, I’m closing; tracked by #1631.

@tophtucker tophtucker closed this Aug 24, 2023
@tophtucker tophtucker deleted the toph/auto-options branch August 24, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants