-
Notifications
You must be signed in to change notification settings - Fork 185
Auto mark tracking issue #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Maybe lower-priority, but not to be forgotten:
|
Yes, we should only implicitly stack when the reduce is count, not when it’s something else. You can always add counts but adding means/medians/etc. often doesn’t make sense. I’ve added your TODO’s to the list above, along with this one. |
sum is also additive :-) I'm adding it to the TODO. |
Setting size to an ordinal dimension shows nothing. That makes sense, since |
Related #493; the data here is being filtered because the size channel implicitly coerces to numbers producing NaN. |
Should we throw an error when a column isn't found in the data? Two notable cases. You might've made a typo (as described in Robert's Levenshtein distance comment #493 (comment), though imo that's overkill):
Or you might've changed the data source, invalidating your column selections:
Other marks don't do this, so I imagine you've considered it and decided against it, but it might fit with Plot.auto's more aggressive and opinionated mandate. |
I think we plan on doing this eventually for all marks as part of #493 (though maybe as a warning rather than an error). I’d like to minimize the “unnecessary” differences between Plot.auto and concrete mark types, where it makes sense; detecting whether the column you referenced exists feels like something that could apply to all marks. I don’t see it as part of the “opinionated defaults” that is the raison d’être for Plot.auto. |
"Error: implicit ordinal position domain has more than 10,000 values" is the most common (only?) error I've been seeing, which makes me itch for limit/sort. Maybe the channel options object could have a limit property; undefined would default to ~20; if null, it wouldn't limit; if it limits, it always sorts? |
Closing this umbrella issue. Please re-open individual feature issues as needed for better tracking. |
Fastfollows from #1238:Bugs
Robustness — aspiring to produce good plots for any combination of options
Options — making more configuration possible
Other enhancements
Plot.auto(numbers).plot()
gives a histogram)Plot.auto(aapl).plot()
)Docs
The text was updated successfully, but these errors were encountered: