Sketch: compile auto mark to explicit marks#1373
Closed
tophtucker wants to merge 14 commits into
Closed
Conversation
Co-authored-by: Mike Bostock <mbostock@gmail.com>
…into toph/never-rect
Member
Author
|
Superseded by #1504 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To satisfy my curiosity, just looking into what it would take.
The easy problem: it should have the accessor in the options, not the materialized array.
The hard problem: I wasn't thinking about this before, but obviously Plot doesn't know the name of the data that was passed in (or rather, it doesn't know the literal expression), so this couldn't really work. And the compiler can't actually execute the code. So… I don't know where this would live. It's both dynamic and needs "reflection". It'd have to be something wild like: editor asks the worker, worker calls this, this returns a function that takes the literal data expression, worker passes that back to editor, editor calls compiler with the returned function, compiler passes in the data source expression, that returns a string which we insert as a new cell…