auto bin options#1277
Merged
Merged
Conversation
Member
Author
|
Also note that you can’t use top-level options for binning, e.g., Plot.auto(weather, {x: "date", thresholds: d3.utcMonth, y: {value: "temp_max", reduce: "mean"}}).plot()That would be nice to add as part of #1261 but we’ll have to address the aforementioned ambiguities. |
tophtucker
approved these changes
Feb 16, 2023
tophtucker
left a comment
tophtucker
left a comment
Member
There was a problem hiding this comment.
👍 Seems like a fine cutoff for now. (I hadn't thought about how bin has options but group doesn't! A telling asymmetry!!)
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* auto bin options * pRetTieR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #1261 #1252, allows x- and y-specific options to be passed through when binning. This is primarily useful for control over thresholds. Given the ambiguities raised in #1261 (review), I’m only doing this for the bin transform; for example you still can’t use scale overrides added in #1247. (I think that’s okay because scale overrides are fairly esoteric, and you can switch to a concrete mark type if needed.)