axis label inset #1516
Open
axis label inset #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #1414
Fil
added a commit
that referenced
this pull request
May 1, 2023
(note: conflicts with #1516, but the merge is trivial)
This was referenced May 1, 2023
|
It might be a bit surprising that the name is inset since the other direction is labelOffset? |
|
As we discussed it would probably be less confusing to call this labelDx (and y), since it's not a segment that we inset, but just a way of translating the label. (We'd lose the relative positioning though, when switching from left to right labelDx would always go →; I think it's fine.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1414
Note: I started by supporting offsetTop, offsetBottom, and inset as a shorthand, but supporting only inset with the “natural“ direction appeared like a simpler option.