axis lineInset and textInset #1519
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I find the word textInset confusing, because I don't immediately see the "extent of reference" that we inset into (since we're already out of the scale's range, so to speak). Also, it doesn't address the center labelAnchor, where there is no natural direction to "inset", but we still might want to move the label to the left or right (or top / bottom). (However, I support removing support for the confusing labelOffset.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1516. Adds lineInset for vertical inset and textInset for horizontal inset, similar to lineAnchor and textAnchor. (Perhaps these should be options on the text mark? Maybe the meaning is wrong if the text is rotated, in which case we should use different names?)