Skip to content

legends #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

legends #539

wants to merge 3 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Sep 10, 2021

legends, extracted from #484

@mbostock mbostock force-pushed the fil/expose-scales-2 branch 2 times, most recently from 62e0e3b to 5f9a553 Compare September 25, 2021 23:48
Base automatically changed from fil/expose-scales-2 to main September 26, 2021 00:32
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an API, how about this?

Plot.legend({color: mycolor, width: 640})

This would potentially allow us to render combined legends for redundant encodings, e.g., when color and radius are used simultaneously. Though maybe to start we’d only support one encoding at a time.

@Fil Fil mentioned this pull request Oct 26, 2021
9 tasks
@Fil
Copy link
Contributor Author

Fil commented Oct 27, 2021

superseded by #583

@Fil Fil closed this Oct 27, 2021
@Fil Fil deleted the fil/expose-scales-legends branch October 27, 2021 16:12
@mbostock mbostock mentioned this pull request Nov 26, 2021
7 tasks
@Fil Fil mentioned this pull request Jan 12, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants