opacity legend #587
Merged
opacity legend #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
fil/legend-opacity
branch
from
42a7526 to
30ed257
Compare
mbostock
reviewed
Nov 25, 2021
Comment on lines
+11
to
+12
| if (!interpolate) throw new Error(`${type} opacity scales are not supported`); | ||
| if (`${legend}`.toLowerCase() !== "ramp") throw new Error(`${legend} opacity legends are not supported`); |
There was a problem hiding this comment.
I added some explicit limitations here; I imagine we’ll add support for other opacity scale types in the future.
mbostock
force-pushed
the
fil/legend-opacity
branch
from
aded8a6 to
273df90
Compare
mbostock
approved these changes
Nov 25, 2021
Fil
added a commit
that referenced
this pull request
Nov 29, 2021
* legends * Plot.legend takes a scale and options * Remove Plot.legend, use chart.legend instead. * reinstate Plot.legend * unused code * allow legend: "ramp" as an option * snapshot test for a lot of color legends * no random in unit tests * remove redundant color tests * accept a label on swatches * className for legendSwatches * remove radius and opacity legends for now * more scope * only color is available in this branch * do not expose any class * error on unknown legend type * categorical is normalized to ordinal * show unknown legend type in error * prEtTieR * prioritize type; avoid unnecessary default * non-nullish, not truthy * div.append(…nodes) * legends * Plot.legend takes a scale and options * Remove Plot.legend, use chart.legend instead. * reinstate Plot.legend * unused code * allow legend: "ramp" as an option * snapshot test for a lot of color legends * no random in unit tests * remove redundant color tests * accept a label on swatches * className for legendSwatches * remove radius and opacity legends for now * more scope * only color is available in this branch * do not expose any class * error on unknown legend type * categorical is normalized to ordinal * show unknown legend type in error * prEtTieR * prioritize type; avoid unnecessary default * non-nullish, not truthy * div.append(…nodes) * less duck typing * remove entity filtering * reduce duck-typing * add a test for Plot.legend with options * styles * clear up some confusion between scale options and legend options * className * apply() rather than color() * Update README * revert figure changes * avoid closure * applyInlineStyles * revert diverging scale changes * inline styles; fix diverging; separate tests * stringify and lowercase legend option * normalizeScale * inherit scale options * fix ordinal tickFormat function * explicit ordinal ticks * use pushState for tests * round option * fix for truncated schemes * opacity legend (#587) * opacity legend * add color option * legend: true * fix test determinism * fix inline opacity legends * arrow key navigation * ignore style if null Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ramp with increasing opacity.
We need to test various possibilities; maybe a checkered background would be nicer; maybe swatches might be useful for some types of opacity scales.