fix: Various improvements to cursor positions in Auto-Suggest

[claremacrae]

Types of changes

Changes visible to users:

• Bug fix (prefix: fix - non-breaking change which fixes an issue)

Internal changes:

• Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
• Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

Fix some unreported inconsistencies in AutoSuggest behaviour, discovered whilst adding support for auto-suggest on a new field.

• fix: Better dataview space & cursor in recurrence suggestions
• fix: Remove the need to type a space after 'id' and 'depends on' selected
• fix: Better dataview space & cursor in 'generate unique id' result

See the "Screenshots" section below for demos of each change.

Motivation and Context

I want to extract some helper functions in Suggestor.ts as it is so repetitive - in doing so, I found some inconsistencies in the code, which explain some inconsistencies in the behaviour.

How has this been tested?

• Automated tests
• Exploratory testing

Screenshots (if appropriate)

In the following text, the | represents the cursor position after the change.

Before

Tasks Format

- [ ] #task Tasks Format - Task 1 🔁 every day |
- [ ] #task Tasks Format - Task 2 🆔|
- [ ] #task Tasks Format - Task 3 ⛔|
- [ ] #task Tasks Format - Task 4 🆔 ousy9q| 

Dataview Format

- [ ] #task Dataview Format - Task 1 [repeat:: every day |]
- [ ] #task Dataview Format - Task 2 [id::|]
- [ ] #task Dataview Format - Task 3 [dependsOn::|]
- [ ] #task Dataview Format - Task 4 [id:: ousy9q| ]

After

Tasks Format

- [ ] #task Tasks Format - Task 1 🔁 every day |
- [ ] #task Tasks Format - Task 2 🆔 |
- [ ] #task Tasks Format - Task 3 ⛔ |
- [ ] #task Tasks Format - Task 4 🆔 ousy9q |

Dataview Format

- [ ] #task Dataview Format - Task 1 [repeat:: every day] |
- [ ] #task Dataview Format - Task 2 [id:: |]
- [ ] #task Dataview Format - Task 3 [dependsOn:: |]
- [ ] #task Dataview Format - Task 4 [id:: ousy9q] |

Checklist

• My code follows the code style of this project and passes yarn run lint.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• My change has adequate Unit Test coverage.

Terms

• My contribution follows this project's contributing guide
• I agree to follow this project's Code of Conduct

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud