Wasm text file preprocessor #1822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhugo
reviewed
Jan 30, 2025
vouillon
force-pushed
the
preprocess
branch
5 times, most recently
from
22aa8ab to
408fc17
Compare
|
Have you considered using this to add sugars to help write control flows (e.g having a |
That seems a good idea, indeed! |
hhugo
reviewed
Feb 3, 2025
hhugo
approved these changes
Feb 3, 2025
vouillon
force-pushed
the
preprocess
branch
6 times, most recently
from
32f8b5d to
28907d4
Compare
vouillon
force-pushed
the
preprocess
branch
3 times, most recently
from
a8f6217 to
18ebdc1
Compare
hhugo
reviewed
Feb 25, 2025
hhugo
reviewed
Feb 25, 2025
hhugo
reviewed
Feb 25, 2025
This provides a better debugging experience since reference to these functions will now use an id rather than a number in disassembled code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a start, it is only used to manage runtime differences between OCaml versions, and to provide some syntactic sugar for strings. But I plan to use it for a WASI version of the runtime and to implement the use-js-string flag.